Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CODE spans stuck to words #9448

Merged
merged 2 commits into from
Nov 2, 2022
Merged

fix: CODE spans stuck to words #9448

merged 2 commits into from
Nov 2, 2022

Conversation

nschonni
Copy link
Contributor

Description

Motivation

Additional details

Related issues and pull requests

@nschonni nschonni requested a review from a team as a code owner October 22, 2022 19:14
@nschonni nschonni requested review from SphinxKnight and removed request for a team October 22, 2022 19:14
@github-actions github-actions bot added the l10n-fr Issues related to French content. label Oct 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2022 •
edited
Loading

Preview URLs (27 pages)
Flaws (176)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /fr/docs/Web/HTML/Date_and_time_formats
Title: Formats de date et d'heure utilisés en HTML
Flaw count: 12

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Can't resolve /fr/docs/Web/HTML/Element/Input
    • Can't resolve /fr/docs/Web/HTML/Element/Input#attr-type
    • Can't resolve /fr/docs/Web/HTML/Element/Input/date
    • Can't resolve /fr/docs/Web/HTML/Element/Input/datetime
    • Can't resolve /fr/docs/Web/HTML/Element/Input/datetime-local
    • and 6 more flaws omitted

URL: /fr/docs/Web/HTML/Global_attributes/draggable
Title: draggable
Flaw count: 5

  • macros:
    • /fr/docs/Web/API/GlobalEventHandlers/ondragstart does not exist but fell back to /en-US/docs/Web/API/HTMLElement/dragstart_event
  • broken_links:
    • Can't resolve /fr/docs/Web/HTML/Attributs_universels
    • Can't resolve /fr/docs/Web/API/API_HTML_Drag_and_Drop
    • Can't resolve /fr/docs/Glisser_et_déposer/Opérations_de_glissement
    • Can't resolve /fr/docs/Web/HTML/Attributs_universels

URL: /fr/docs/Web/HTML/Element/input/checkbox
Title: <input type="checkbox">
Flaw count: 8

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • /fr/docs/Web/API/HTMLInputElement/select does not exist but fell back to /en-US/docs/Web/API/HTMLInputElement/select
    • /fr/docs/Web/CSS/indeterminate does not exist
  • heading_links:
    • h3 heading contains an <a> tag
    • h3 heading contains an <a> tag
  • translation_differences:
    • Differences in the important macros (4 in common of 11 possible)

URL: /fr/docs/Web/HTML/Element/Heading_Elements
Title: <h1>-<h6> : les éléments de titre de section
Flaw count: 9

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Can't resolve /fr/docs/Web/HTML/Attributs_universels
    • Anchor not lowercase
    • Can use the English (en-US) link as a fallback
    • Anchor not lowercase
    • Can't resolve /fr/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-labelledby_attribute
    • and 1 more flaws omitted
  • translation_differences:
    • Differences in the important macros (3 in common of 7 possible)

URL: /fr/docs/Web/HTML/Element/link
Title: <link> : l'élément de lien vers des ressources externes
Flaw count: 23

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • /fr/docs/Web/API/HTMLLinkElement does not exist but fell back to /en-US/docs/Web/API/HTMLLinkElement
  • broken_links:
    • Can't resolve /fr/docs/Glossaire/CSS
    • Can't resolve /fr/docs/Web/HTML/Types_de_lien
    • Can't resolve /fr/docs/Web/HTML/Précharger_du_contenu
    • Can't resolve /fr/docs/Web/HTML/Attributs_universels
    • Can't resolve /fr/docs/HTTP/CSP
    • and 12 more flaws omitted
  • translation_differences:
    • Differences in the important macros (2 in common of 4 possible)

URL: /fr/docs/Web/HTML/Element/video
Title: <video>
Flaw count: 42

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /fr/docs/Web/API/ScriptProcessorNode does not exist but fell back to /en-US/docs/Web/API/ScriptProcessorNode
    • /fr/docs/Web/API/OfflineAudioContext does not exist but fell back to /en-US/docs/Web/API/OfflineAudioContext
    • /fr/docs/Web/API/HTMLMediaElement/loadeddata_event does not exist but fell back to /en-US/docs/Web/API/HTMLMediaElement/loadeddata_event
    • /fr/docs/Web/API/HTMLMediaElement/loadedmetadata_event does not exist but fell back to /en-US/docs/Web/API/HTMLMediaElement/loadedmetadata_event
    • and 17 more flaws omitted
  • broken_links:
    • Can't resolve /fr/docs/Web/HTML/Formats_pour_audio_video
    • Can use the English (en-US) link as a fallback
    • Can't resolve /fr/docs/Web/Guide/DOM/Events/evenement_medias
    • Can use the English (en-US) link as a fallback
    • Can't resolve /fr/docs/Apprendre/HTML/Multimedia_and_embedding/Contenu_audio_et_video
    • and 14 more flaws omitted
  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)

URL: /fr/docs/Web/HTML/Attributes/autocomplete
Title: Attribut HTML : autocomplete
Flaw count: 7

  • broken_links:
    • Can't resolve /fr/docs/Web/HTML/Element/Input
    • Can't resolve /fr/docs/Web/HTML/Element/Input
    • Can't resolve /fr/docs/Web/HTML/Element/Input#attr-form
    • Can't resolve /fr/docs/Web/HTML/Element/Input/submit
    • Can use the English (en-US) link as a fallback
    • and 2 more flaws omitted

URL: /fr/docs/Web/CSS/top
Title: top
Flaw count: 2

  • broken_links:
    • Can't resolve /fr/Apprendre/CSS/Les_bases/La_disposition#Le_positionnement
  • translation_differences:
    • Differences in the important macros (5 in common of 8 possible)

URL: /fr/docs/Web/CSS/@media/prefers-color-scheme
Title: prefers-color-scheme
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (2 in common of 6 possible)

URL: /fr/docs/Web/CSS/transform-function
Title: transform-function
Flaw count: 22

  • broken_links:
    • Can't resolve /fr/docs/Web/CSS/transform-function/matrix()
    • Can't resolve /fr/docs/Web/CSS/transform-function/matrix3d()
    • Can't resolve /fr/docs/Web/CSS/transform-function/perspective()
    • Can't resolve /fr/docs/Web/CSS/transform-function/rotate()
    • Can't resolve /fr/docs/Web/CSS/transform-function/rotate3d()
    • and 16 more flaws omitted
  • translation_differences:
    • Differences in the important macros (3 in common of 4 possible)

URL: /fr/docs/Web/CSS/abs
Title: abs()
Flaw count: 3

  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (4 in common of 5 possible)

URL: /fr/docs/Web/CSS/CSS_Flow_Layout/Intro_to_formatting_contexts
Title: Explications quant aux contextes de formatage
Flaw count: 7

  • broken_links:
    • Can't resolve /fr/docs/Web/CSS/Modèle_de_boîte_CSS/Fusion_des_marges
    • Can't resolve /fr/docs/Web/CSS/CSS_Flexible_Box_Layout/Concepts_de_base_flexbox
    • Can't resolve /fr/docs/Web/CSS/CSS_Grid_Layout/Les_concepts_de_base
    • Can't resolve /fr/docs/Web/CSS/CSS_Flow_Layout/Disposition_flux_et_modes_écriture
    • Can't resolve /fr/docs/Web/CSS/Block_formatting_context
    • and 2 more flaws omitted

URL: /fr/docs/Web/CSS/font
Title: font
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /fr/docs/Web/CSS/CSS_Colors/Applying_color
Title: Appliquer des couleurs sur des éléments HTML grâce à CSS
Flaw count: 11

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Can't resolve /fr/docs/Web/HTML/Element/Input
    • Is currently http:// but can become https://
    • Can't resolve /fr/docs/Web/HTML/Element/Input
    • Can't resolve /fr/docs/Web/HTML/Element/Input#attr-type
    • Can't resolve /fr/docs/Web/HTML/Element/Input/color
    • and 4 more flaws omitted
  • translation_differences:
    • Differences in the important macros (0 in common of 7 possible)

URL: /fr/docs/Web/CSS/border-right-color
Title: border-right-color
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /fr/docs/Web/CSS/CSS_Grid_Layout/Realizing_common_layouts_using_CSS_Grid_Layout
Title: Construire des dispositions courantes avec des grilles CSS
Flaw count: 3

  • broken_links:
    • Can't resolve /fr/docs/Tools/Page_Inspector/How_to/Examine_grid_layouts
    • Can't resolve /fr/docs/Tools/Page_Inspector/How_to/Examine_grid_layouts
  • translation_differences:
    • Differences in the important macros (1 in common of 11 possible)

URL: /fr/docs/Web/CSS/:nth-last-child
Title: :nth-last-child
Flaw count: 3

  • broken_links:
    • Can't resolve /fr/docs/CSS/Pseudo-classes
    • Can't resolve /fr/docs/Web/CSS/Sélecteurs_de_voisins_généraux
  • translation_differences:
    • Differences in the important macros (3 in common of 10 possible)

URL: /fr/docs/Web/CSS/clip
Title: clip
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (4 in common of 6 possible)

URL: /fr/docs/Web/CSS/border-left-color
Title: border-left-color
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /fr/docs/Web/CSS/border-bottom-color
Title: border-bottom-color
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /fr/docs/Web/CSS/:defined
Title: :defined
Flaw count: 2

  • broken_links:
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (3 in common of 4 possible)

URL: /fr/docs/Web/CSS/CSS_Flexible_Box_Layout/Basic_Concepts_of_Flexbox
Title: Les concepts de base pour flexbox
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (7 in common of 11 possible)

URL: /fr/docs/Web/CSS/CSS_Box_Alignment/Box_Alignment_in_Flexbox
Title: L'alignement des boîtes avec Flexbox
Flaw count: 4

  • broken_links:
    • Can't resolve /fr/docs/Glossaire/Axe_transversal
    • Can't resolve /fr/docs/Glossaire/Axe_principal
    • Can't resolve /fr/docs/Web/CSS/Disposition_flexbox_CSS/Aligner_des_éléments_dans_un_conteneur_flexible
  • translation_differences:
    • Differences in the important macros (3 in common of 4 possible)

URL: /fr/docs/Web/HTTP/Link_prefetching_FAQ
Title: FAQ sur le préchargement des liens
Flaw count: 3

  • macros:
    • This macro has been deprecated, and should be removed.
  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /fr/docs/Web/HTTP/Caching
Title: Mise en cache HTTP
Flaw count: 3

  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase

(this comment was updated 2022-10-24 17:22:35.570849)

cw118
cw118 reviewed Oct 22, 2022
View reviewed changes
files/fr/web/html/date_and_time_formats/index.md
@@ -296,7 +296,7 @@ Une chaîne de caractères représentant une heure peut décrire différentes pr

Voici quelques règles supplémentaires :

- L'heure est toujours exprimée selon une horloge sur 24 heures où `00` correspond à minuit et où `23` correspond à onze heures du soir. Aucune valeur en dehors de l'intervalle `00`-`23` n'est autorisée.
- L'heure est toujours exprimée selon une horloge sur 24 heures où `00` correspond à minuit et où `23` correspond à onze heures du soir. Aucune valeur en dehors de l'intervalle `00` - `23` n'est autorisée.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this one as it's a range of numbers, and the en-US file is the same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one I'm doing an upstream PR for

Copy link
Member

@cw118 cw118 Oct 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's OK, I would prefer to wait for the upstream PR. It seems to me that a range of numbers should be written num1-num2 without spaces between the numbers and the dash, so perhaps the way to fix this would be num1-num2, but I would like to see what the en-US reviewers say/do :)

(I am really nitpicking here 😅)

SphinxKnight
SphinxKnight approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@SphinxKnight SphinxKnight left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks once again @nschonni
Edit: just saw @cw118 review, I'll leave this one pending, feel free to merge when you think it's OK @cw118 :)

@cw118 cw118 self-assigned this Oct 24, 2022
@cw118
Copy link
Member

cw118 commented Nov 2, 2022

Let's merge this (for now at least), thank you @nschonni !

@cw118 cw118 merged commit 4e157af into mdn:main Nov 2, 2022
@nschonni nschonni deleted the stuck-code-fr2 branch November 2, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cw118 cw118 cw118 left review comments

@SphinxKnight SphinxKnight SphinxKnight approved these changes

Assignees

@cw118 cw118

Labels
l10n-fr Issues related to French content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nschonni @cw118 @SphinxKnight