-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown conversion for ru
- Replace - XPath section ⚠️ Do not squash merge ⚠️
#8601
Markdown conversion for ru
- Replace - XPath section ⚠️ Do not squash merge ⚠️
#8601
Conversation
Please |
Preview URLsFlawsNote! 2 documents with no flaws that don't need to be listed. 🎉 URL:
|
|
||
Поддерживается | ||
|
||
{{ languages( { "fr": "fr/XPath/Fonctions/floor", "ja": "ja/XPath/Functions/floor", "pl": "pl/XPath/Funkcje/floor", "en": "en/XPath/Fonctions/floor" } ) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this macro?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No we don't, {{languages}}
can be removed (it's a source of possible later errors due to mdn/yari#4744 and #5603
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say such a removal may has its place in a "cleanup" PR. Do you want me to open a PR to remove {{languages}}
for this section and rebase this current PR on top of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. Let's do it after migration
No conversion report as there were no error