Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown conversion for ru - Replace - XPath section ⚠️ Do not squash merge ⚠️ #8601

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

SphinxKnight
Copy link
Member

No conversion report as there were no error

@SphinxKnight SphinxKnight added l10n-ru Issues related to Russian content. markdown-conversion 100% markdown project labels Sep 18, 2022
@SphinxKnight SphinxKnight added this to the Markdown conversion milestone Sep 18, 2022
@SphinxKnight SphinxKnight requested a review from a team as a code owner September 18, 2022 05:14
@SphinxKnight SphinxKnight requested review from myshov and removed request for a team September 18, 2022 05:14
@SphinxKnight
Copy link
Member Author

Please ⚠️ Do not squash merge ⚠️

@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /ru/docs/Web/XPath/Functions/floor
Title: Floor
Flaw count: 3

  • macros:
    • This macro has been deprecated, and should be removed.
  • broken_links:
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (0 in common of 1 possible)


Поддерживается

{{ languages( { "fr": "fr/XPath/Fonctions/floor", "ja": "ja/XPath/Functions/floor", "pl": "pl/XPath/Funkcje/floor", "en": "en/XPath/Fonctions/floor" } ) }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this macro?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we don't, {{languages}} can be removed (it's a source of possible later errors due to mdn/yari#4744 and #5603

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say such a removal may has its place in a "cleanup" PR. Do you want me to open a PR to remove {{languages}} for this section and rebase this current PR on top of it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. Let's do it after migration

@sashasushko sashasushko merged commit b1f3523 into mdn:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ru Issues related to Russian content. markdown-conversion 100% markdown project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants