Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown conversion for pt-BR - Replace - Manifest section ⚠️ Do not squash ⚠️ #8522

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

@SphinxKnight SphinxKnight requested a review from a team as a code owner September 15, 2022 05:38
@SphinxKnight SphinxKnight requested review from nathipg and removed request for a team September 15, 2022 05:38
@SphinxKnight SphinxKnight added l10n-pt-br Issues related to Brazilian Portuguese markdown-conversion 100% markdown project labels Sep 15, 2022
@SphinxKnight SphinxKnight added this to the Markdown conversion milestone Sep 15, 2022
@SphinxKnight
Copy link
Member Author

SphinxKnight commented Sep 15, 2022

Please ⚠️ Do not squash merge ⚠️

@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /pt-BR/docs/Web/Manifest
Title: Web App Manifest
Flaw count: 9

  • macros:
    • /pt-BR/docs/Glossary/Browsing_context does not exist but fell back to /en-US/docs/Glossary/Browsing_context
    • This macro has been deprecated, and should be removed.
    • This macro has been deprecated, and should be removed.
    • Calling the Compat macro with any arguments is deprecated; instead use the 'browser-compat' front-matter key.
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can't resolve /docs/Web/CSS/@media/display-mode
  • translation_differences:
    • Differences in the important macros (0 in common of 2 possible)
  • bad_bcd_links:
    • no explanation!
    • no explanation!

External URLs

URL: /pt-BR/docs/Web/Manifest
Title: Web App Manifest

@nathipg
Copy link
Member

nathipg commented Sep 19, 2022

Please ⚠️ Do not squash merge ⚠️

Could you tell me why, please?

@SphinxKnight
Copy link
Member Author

Please ⚠️ Do not squash merge ⚠️

Could you tell me why, please?

If squashed, the git history of a given file will be "cut"/split: there will be one timeline for the HTML file and a subsequent one for the MD file (but no link between them). Not squashing the "move"+"convert" commits allow us to keep the same timeline for the converted files.

Please let me know if this is unclear 🙇

@nathipg
Copy link
Member

nathipg commented Sep 26, 2022

Please ⚠️ Do not squash merge ⚠️

Could you tell me why, please?

If squashed, the git history of a given file will be "cut"/split: there will be one timeline for the HTML file and a subsequent one for the MD file (but no link between them). Not squashing the "move"+"convert" commits allow us to keep the same timeline for the converted files.

Please let me know if this is unclear 🙇

Thank you! I didn't know that

@nathipg nathipg merged commit a80066a into mdn:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-pt-br Issues related to Brazilian Portuguese markdown-conversion 100% markdown project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants