-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown conversion for pt-BR
- Replace - Events section ⚠️ Do not squash ⚠️
#8519
Markdown conversion for pt-BR
- Replace - Events section ⚠️ Do not squash ⚠️
#8519
Conversation
Please |
Preview URLs Flaws (1009)URL:
External URLs (7)URL:
(this comment was updated 2022-09-26 12:06:30.399954) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nathipg I'll check what's going on |
OK the headings are in the tables. I'm going to submit another PR to fix that "upstream" and will rebase this one so that it only converts stuff. |
Waiting for #8836 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ;)
9485308
to
292105e
Compare
@josielrocha do you want to merge #8836 beforehand? :) |
Move caption headings to fix/help with #8519
292105e
to
28a54e1
Compare
28a54e1
to
0e7efda
Compare
since the headings are fixed (cf. preview) and that @josielrocha approved earlier, I'm going to merge this one. |
No previous PR about this one since there were no error in the first place.