Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown conversion for pt-BR - Replace - Events section ⚠️ Do not squash ⚠️ #8519

Merged

Conversation

SphinxKnight
Copy link
Member

No previous PR about this one since there were no error in the first place.

@SphinxKnight SphinxKnight added l10n-pt-br Issues related to Brazilian Portuguese markdown-conversion 100% markdown project labels Sep 15, 2022
@SphinxKnight SphinxKnight added this to the Markdown conversion milestone Sep 15, 2022
@SphinxKnight SphinxKnight requested a review from a team as a code owner September 15, 2022 05:17
@SphinxKnight SphinxKnight requested review from nathipg and removed request for a team September 15, 2022 05:17
@SphinxKnight
Copy link
Member Author

Please ⚠️ Do not squash merge ⚠️

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2022

Preview URLs

Flaws (1009)

URL: /pt-BR/docs/Web/Events
Title: Event reference
Flaw count: 1009

  • macros:
    • This macro has been deprecated, and should be removed.
    • This macro has been deprecated, and should be removed.
    • This macro has been deprecated, and should be removed.
    • This macro has been deprecated, and should be removed.
    • This macro has been deprecated, and should be removed.
    • and 635 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can't resolve /en-US/docs/Web/Reference/Events/open_websocket
    • Can't resolve /en-US/docs/Web/Reference/Events/message_websocket
    • Can't resolve /en-US/docs/Web/Reference/Events/close_websocket
    • Can't resolve /en-US/docs/XPCOM_Interface_Reference/NsIDOMHTMLMediaElement
    • and 363 more flaws omitted
  • translation_differences:
    • Differences in the important macros (0 in common of 1 possible)
External URLs (7)

URL: /pt-BR/docs/Web/Events
Title: Event reference

(this comment was updated 2022-09-26 12:06:30.399954)

Copy link
Member

@nathipg nathipg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some titles from this page disapeared.

This version:

image

Current version:

image

Could you gave a look, please?

@SphinxKnight SphinxKnight self-assigned this Sep 26, 2022
@SphinxKnight
Copy link
Member Author

Thanks @nathipg I'll check what's going on

@SphinxKnight
Copy link
Member Author

OK the headings are in the tables. I'm going to submit another PR to fix that "upstream" and will rebase this one so that it only converts stuff.

SphinxKnight added a commit to SphinxKnight/translated-content that referenced this pull request Sep 26, 2022
@SphinxKnight SphinxKnight marked this pull request as draft September 26, 2022 10:30
@SphinxKnight
Copy link
Member Author

Waiting for #8836

Copy link
Collaborator

@josielrocha josielrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

@SphinxKnight SphinxKnight force-pushed the pt-br-events-md-conversion-replace branch from 9485308 to 292105e Compare September 26, 2022 11:49
@SphinxKnight
Copy link
Member Author

LGTM ;)

@josielrocha do you want to merge #8836 beforehand? :)

SphinxKnight added a commit that referenced this pull request Sep 26, 2022
Move caption headings to fix/help with #8519
@SphinxKnight SphinxKnight force-pushed the pt-br-events-md-conversion-replace branch from 292105e to 28a54e1 Compare September 26, 2022 11:58
@SphinxKnight SphinxKnight force-pushed the pt-br-events-md-conversion-replace branch from 28a54e1 to 0e7efda Compare September 26, 2022 12:03
@SphinxKnight SphinxKnight marked this pull request as ready for review September 26, 2022 12:06
@SphinxKnight
Copy link
Member Author

since the headings are fixed (cf. preview) and that @josielrocha approved earlier, I'm going to merge this one.

@SphinxKnight SphinxKnight merged commit 2813633 into mdn:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-pt-br Issues related to Brazilian Portuguese markdown-conversion 100% markdown project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants