Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown conversion for pt-BR - Replace - API section ⚠️ Do not squash ⚠️ #8517

Merged
merged 6 commits into from
Sep 19, 2022

Conversation

@SphinxKnight SphinxKnight added l10n-pt-br Issues related to Brazilian Portuguese markdown-conversion 100% markdown project labels Sep 15, 2022
@SphinxKnight SphinxKnight added this to the Markdown conversion milestone Sep 15, 2022
@SphinxKnight SphinxKnight requested a review from a team as a code owner September 15, 2022 05:10
@SphinxKnight SphinxKnight requested review from josielrocha and removed request for a team September 15, 2022 05:10
@SphinxKnight
Copy link
Member Author

Please ⚠️ Do not squash merge ⚠️

Copy link
Collaborator

@josielrocha josielrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SphinxKnight,
Thank you for your precious contribution.

I have made some suggestions and I would appreciate if you could check them.
Thank you a lot!

---
{{APIRef("DOM")}}

O **E\*\***lement.classList\*\* é uma propriedade somente leitura que retorna uma coleção {{domxref ("DOMTokenList")}} ativa dos atributos de classe do elemento.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
O **E\*\***lement.classList\*\* é uma propriedade somente leitura que retorna uma coleção {{domxref ("DOMTokenList")}} ativa dos atributos de classe do elemento.
O **`Element.classList`** é uma propriedade somente leitura que retorna uma coleção {{domxref ("DOMTokenList")}} ativa dos atributos de classe do elemento.

files/pt-br/web/api/animation/currenttime/index.md Outdated Show resolved Hide resolved
files/pt-br/web/api/animation/index.md Outdated Show resolved Hide resolved
files/pt-br/web/api/animation/playstate/index.md Outdated Show resolved Hide resolved
files/pt-br/web/api/audionode/index.md Outdated Show resolved Hide resolved
---
{{APIRef}}

O método **`CanvasRenderingContext2D`\*\***`.stroke()`\*\* da API Canvas 2D contorna um dado _path_ ou o _path_ atual com o estilo atual de traçado usando uma regra de controle diferente de zero.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
O método **`CanvasRenderingContext2D`\*\***`.stroke()`\*\* da API Canvas 2D contorna um dado _path_ ou o _path_ atual com o estilo atual de traçado usando uma regra de controle diferente de zero.
O método **`CanvasRenderingContext2D.stroke()** da API Canvas 2D contorna um dado _path_ ou o _path_ atual com o estilo atual de traçado usando uma regra de controle diferente de zero.

---
{{APIRef}}

O método **`CanvasRenderingContext2D`\*\***`.strokeRect()`\*\* da API Canvas 2D desenha um retângulo na posição _(x, y)_, que possui uma largura\_ _(\_width_) _w_ e uma altura (_height_) _h_`,` e não tem nenhum preenchimento (estilo _stroke_).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
O método **`CanvasRenderingContext2D`\*\***`.strokeRect()`\*\* da API Canvas 2D desenha um retângulo na posição _(x, y)_, que possui uma largura\_ _(\_width_) _w_ e uma altura (_height_) _h_`,` e não tem nenhum preenchimento (estilo _stroke_).
O método **`CanvasRenderingContext2D.strokeRect()`** da API Canvas 2D desenha um retângulo na posição _(x, y)_, que possui uma largura\_ _(\_width_) _w_ e uma altura (_height_) _h_`,` e não tem nenhum preenchimento (estilo _stroke_).

---
{{APIRef}}

O método **`CanvasRenderingContext2D`\*\***`.rect()`\*\* da Canvas 2D API cria um _path_ (trajeto) para um retângulo na posição _(x, y)_, cujo tamanho é determinado pelo _width_ (largura) e _height_ (altura). Esses quatro pontos estão conectados por linhas retas e o _sub-path_ (sub-trajeto) é marcado como fechado, para que você possa `fill (preencher)` ou `stroke (contornar)` o retângulo.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
O método **`CanvasRenderingContext2D`\*\***`.rect()`\*\* da Canvas 2D API cria um _path_ (trajeto) para um retângulo na posição _(x, y)_, cujo tamanho é determinado pelo _width_ (largura) e _height_ (altura). Esses quatro pontos estão conectados por linhas retas e o _sub-path_ (sub-trajeto) é marcado como fechado, para que você possa `fill (preencher)` ou `stroke (contornar)` o retângulo.
O método **`CanvasRenderingContext2D.rect()** da Canvas 2D API cria um _path_ (trajeto) para um retângulo na posição _(x, y)_, cujo tamanho é determinado pelo _width_ (largura) e _height_ (altura). Esses quatro pontos estão conectados por linhas retas e o _sub-path_ (sub-trajeto) é marcado como fechado, para que você possa `fill (preencher)` ou `stroke (contornar)` o retângulo.

---
{{APIRef("Websockets API")}}

O construtor **`CloseEvent()`**cria uma nova instância {{domxref("CloseEvent")}}.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
O construtor **`CloseEvent()`**cria uma nova instância {{domxref("CloseEvent")}}.
O construtor **`CloseEvent()`** cria uma nova instância {{domxref("CloseEvent")}}.

---
{{APIRef("DOM")}}

O metodo `document.close()` termina a gravação em um documento, aberto com [document.open()](/en/DOM/document.open "en/DOM/document.open").
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
O metodo `document.close()` termina a gravação em um documento, aberto com [document.open()](/en/DOM/document.open "en/DOM/document.open").
O método **`document.close()`** termina a gravação em um documento, aberto com [document.open()](/en/DOM/document.open "en/DOM/document.open").

@SphinxKnight
Copy link
Member Author

Hi @SphinxKnight, Thank you for your precious contribution.

I have made some suggestions and I would appreciate if you could check them. Thank you a lot!

I would apply the ones related to "markdown-conversion" related issues. Otherwise, I think it would be best to address the rest later (ex. #8517 (comment) which was already an issue before the conversion). Moreover, since this PR's commits will not be squashed, that means introducing "more" commits to the main history.

I can file issues for each comment if you prefer. That way, we can fix them afterwards.

Please let me know, I don't want to block things and if you definitely prefer introducing those changes now, I'll comply :)

@josielrocha
Copy link
Collaborator

Hi @SphinxKnight, Thank you for your precious contribution.
I have made some suggestions and I would appreciate if you could check them. Thank you a lot!

I would apply the ones related to "markdown-conversion" related issues. Otherwise, I think it would be best to address the rest later (ex. #8517 (comment) which was already an issue before the conversion). Moreover, since this PR's commits will not be squashed, that means introducing "more" commits to the main history.

I can file issues for each comment if you prefer. That way, we can fix them afterwards.

Please let me know, I don't want to block things and if you definitely prefer introducing those changes now, I'll comply :)

It sounds good! Let's fix that after Markdown migration.

@SphinxKnight
Copy link
Member Author

@josielrocha sorry for the rush previously, I've re-read the comments and only one was an actual "content" update, I've filed an issue for it and applied the rest of the suggestions :)

Thanks!

@SphinxKnight
Copy link
Member Author

SphinxKnight commented Sep 19, 2022

And I'll file an issue to check for patterns with ** being escaped afterwards, I know we had to deal with some of them in fr

@SphinxKnight SphinxKnight merged commit f49f914 into mdn:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment