Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown conversion for pt-BR - Replace - Learning Area section ⚠️ Do not squash ⚠️ #8513

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Markdown conversion for pt-BR - Replace - Learning Area section ⚠️ Do not squash ⚠️ #8513

merged 3 commits into from
Oct 6, 2022

Conversation

SphinxKnight
Copy link
Member

@SphinxKnight SphinxKnight added l10n-pt-br Issues related to Brazilian Portuguese markdown-conversion 100% markdown project labels Sep 15, 2022
@SphinxKnight SphinxKnight added this to the Markdown conversion milestone Sep 15, 2022
@SphinxKnight SphinxKnight requested a review from a team as a code owner September 15, 2022 04:53
@SphinxKnight SphinxKnight requested review from nathipg and removed request for a team September 15, 2022 04:53
@SphinxKnight SphinxKnight mentioned this pull request Sep 15, 2022
Closed
@SphinxKnight
Copy link
Member Author

Please ⚠️ Do not squash merge ⚠️

@github-actions

This comment was marked as off-topic.

Sign in to view
@SphinxKnight SphinxKnight force-pushed the pt-br-learn-md-conversion-replace branch from e68408c to 292af90 Compare September 26, 2022 11:14
@SphinxKnight
Copy link
Member Author

Conversion report updated after rebasing this work up onto upstream to fix conflicts https://gist.github.com/SphinxKnight/e66a41050cc8314ab9fcfd527ef8201f#file-md-conversion-problems-report-2022-09-26t11_12_11-415z-md

josielrocha
josielrocha reviewed Oct 1, 2022
View reviewed changes
Copy link
Collaborator

@josielrocha josielrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SphinxKnight!

Thank you for your contribution.
I have found some issues, could you please fix them?

files/pt-br/learn/forms/your_first_form/index.md Outdated Show resolved Hide resolved
files/pt-br/learn/forms/your_first_form/index.md Outdated Show resolved Hide resolved
files/pt-br/learn/forms/your_first_form/index.md Outdated Show resolved Hide resolved
files/pt-br/learn/forms/your_first_form/index.md Outdated Show resolved Hide resolved
josielrocha
josielrocha approved these changes Oct 6, 2022
View reviewed changes
Copy link
Collaborator

@josielrocha josielrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

@SphinxKnight SphinxKnight merged commit dc67e28 into mdn:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josielrocha josielrocha josielrocha approved these changes

@nathipg nathipg Awaiting requested review from nathipg nathipg is a code owner automatically assigned from mdn/yari-content-pt-br

Assignees
No one assigned
Labels
l10n-pt-br Issues related to Brazilian Portuguese markdown-conversion 100% markdown project
Projects
None yet
Milestone
Markdown conversion
Development

Successfully merging this pull request may close these issues.
2 participants
@SphinxKnight @josielrocha