Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown conversion for pt-BR - Replace - CSS section ⚠️ Do not squash ⚠️ #8422

Merged
merged 3 commits into from
Sep 12, 2022

Conversation

@SphinxKnight SphinxKnight requested a review from a team as a code owner September 11, 2022 09:23
@SphinxKnight SphinxKnight requested review from josielrocha and removed request for a team September 11, 2022 09:23
@SphinxKnight SphinxKnight added the l10n-pt-br Issues related to Brazilian Portuguese label Sep 11, 2022
@SphinxKnight SphinxKnight added this to the Markdown conversion milestone Sep 11, 2022
@SphinxKnight
Copy link
Member Author

Please ⚠️ Do not squash merge ⚠️

@mdn/yari-content-pt-br / @josielrocha Could you please check this one in the coming days as conflicts are very likely to arise / this PR is liely to be stale if other edits occur on the same subset of pages. Thank you 🙏

@github-actions

This comment was marked as off-topic.

Copy link
Collaborator

@josielrocha josielrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot for this awesome work @SphinxKnight!

I found a lot of issues related to chunks not translated properly, but it was already there before your changes. So I am focusing on Markdown conversion. As soon as you merge this Pull Request I am opening issues for the pages where I found that issues.

Thank you again!

@josielrocha josielrocha added the markdown-conversion 100% markdown project label Sep 11, 2022
@SphinxKnight SphinxKnight merged commit ac9a095 into mdn:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-pt-br Issues related to Brazilian Portuguese markdown-conversion 100% markdown project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants