Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown conversion for pt-BR - Cleanup - JavaScript section #7970

Merged
merged 4 commits into from
Sep 14, 2022

Conversation

SphinxKnight
Copy link
Member

Here is the conversion report after those steps: https://gist.github.com/SphinxKnight/e66a41050cc8314ab9fcfd527ef8201f#file-md-conversion-problems-report-2022-08-24t11_56_01-204z-md

N.B. this PR does not convert the content, merely prepares it for conversion.

@SphinxKnight SphinxKnight added the markdown-conversion 100% markdown project label Aug 24, 2022
@SphinxKnight SphinxKnight requested a review from a team as a code owner August 24, 2022 11:58
@SphinxKnight SphinxKnight requested review from clovislima and removed request for a team August 24, 2022 11:58
@SphinxKnight SphinxKnight added the l10n-pt-br Issues related to Brazilian Portuguese label Aug 24, 2022
@github-actions

This comment was marked as off-topic.

@josielrocha
Copy link
Collaborator

Hi @SphinxKnight,

Thank you a lot for your contribution. Unfortunatelly there are some conflicts in these files:

files/pt-br/web/javascript/a_re-introduction_to_javascript/index.html
files/pt-br/web/javascript/closures/index.html
files/pt-br/web/javascript/reference/global_objects/array/flatmap/index.html

Could you please fix them and mention me?
I would be glad to review your PR again ;)

@SphinxKnight
Copy link
Member Author

Thanks @josielrocha I've merged based on main and rechecked the markdown conversion tool and edited accordingly. Here is the updated conversion report: https://gist.github.com/SphinxKnight/e66a41050cc8314ab9fcfd527ef8201f#file-md-conversion-problems-report-2022-09-10t15_14_42-826z-md

Copy link
Collaborator

@josielrocha josielrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-pt-br Issues related to Brazilian Portuguese markdown-conversion 100% markdown project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants