Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web/api/performanceobserver h2m Performance observer #7280

Merged
merged 2 commits into from
Aug 1, 2022
Merged

web/api/performanceobserver h2m Performance observer #7280

merged 2 commits into from
Aug 1, 2022

Conversation

fwqaaq
Copy link
Contributor

@fwqaaq fwqaaq commented Jul 31, 2022

  • It still has fields that are not modem In browser compatibility when I use yari to convert html to md
  • {{Compat("api.PerformanceObserver.PerformanceObserver")}}

@fwqaaq fwqaaq requested a review from a team as a code owner July 31, 2022 20:38
@fwqaaq fwqaaq requested review from irvin and removed request for a team July 31, 2022 20:38
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Jul 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2022

Preview URLs

Flaws

Note! 4 documents with no flaws that don't need to be listed. 🎉

URL: /zh-CN/docs/Web/API/PerformanceObserver/PerformanceObserver
Title: PerformanceObserver()
on GitHub
Flaw count: 1

  • macros:
    • /zh-CN/docs/Web/API/PerformanceObserverEntryList does not exist but fell back to /en-US/docs/Web/API/PerformanceObserverEntryList

External URLs

URL: /zh-CN/docs/Web/API/PerformanceObserver
Title: 性能监测对象
on GitHub

No new external URLs


URL: /zh-CN/docs/Web/API/PerformanceObserver/takeRecords
Title: PerformanceObserver.takeRecords()
on GitHub

No new external URLs


URL: /zh-CN/docs/Web/API/PerformanceObserver/PerformanceObserver
Title: PerformanceObserver()
on GitHub

No new external URLs


URL: /zh-CN/docs/Web/API/PerformanceObserver/observe
Title: PerformanceObserver.observe()
on GitHub

No new external URLs


URL: /zh-CN/docs/Web/API/PerformanceObserver/disconnect
Title: PeformanceObserver.disconnect()
on GitHub

No new external URLs

(this comment was updated 2022-08-01 02:00:37.548234)

@fwqaaq fwqaaq changed the title Performance observer web/api/performanceobserver h2m Performance observer Jul 31, 2022
@yin1999
Copy link
Member

yin1999 commented Jul 31, 2022

Hi @jack-zhang-1314, cloud you change the first commit (4ec0459) message?

@yin1999 yin1999 removed the request for review from irvin July 31, 2022 23:31
@fwqaaq
Copy link
Contributor Author

fwqaaq commented Aug 1, 2022

Hi @jack-zhang-1314, cloud you change the first commit (4ec0459) message?

yeah, to save the previous commit information

@yin1999
Copy link
Member

yin1999 commented Aug 1, 2022

Hi @jack-zhang-1314, cloud you change the first commit (4ec0459) message?

yeah, to save the previous commit information

message means E:/github/git/zh-cn/web/api/performanceocserver convert html to md, could you use relative path in message?

@yin1999
Copy link
Member

yin1999 commented Aug 1, 2022

message means E:/github/git/zh-cn/web/api/performanceocserver convert html to md, could you use relative path in message?

And, please squash the last two commits

@fwqaaq
Copy link
Contributor Author

fwqaaq commented Aug 1, 2022

Hi @jack-zhang-1314, cloud you change the first commit (4ec0459) message?

yeah, to save the previous commit information

message means E:/github/git/zh-cn/web/api/performanceocserver convert html to md, could you use relative path in message?

  • could you modify the commit message?
  • And using git gc to squash?

@yin1999
Copy link
Member

yin1999 commented Aug 1, 2022

  • could you modify the commit message?

yes

  • And using git gc to squash?

See: https://docs.github.com/en/get-started/using-git/about-git-rebase#commands-available-while-rebasing, squash command

@fwqaaq
Copy link
Contributor Author

fwqaaq commented Aug 1, 2022

like this?

@yin1999
Copy link
Member

yin1999 commented Aug 1, 2022

like this?

Yes, and please modify the commit message

@fwqaaq
Copy link
Contributor Author

fwqaaq commented Aug 1, 2022

Yes, and please modify the commit message

I don't know how to modify the first commit message? could you help me

@yin1999
Copy link
Member

yin1999 commented Aug 1, 2022

 Changes to be committed:
	renamed:    files/zh-cn/web/api/performanceobserver/disconnect/index.html -> files/zh-cn/web/api/performanceobserver/disconnect/index.md
	renamed:    files/zh-cn/web/api/performanceobserver/index.html -> files/zh-cn/web/api/performanceobserver/index.md
	renamed:    files/zh-cn/web/api/performanceobserver/observe/index.html -> files/zh-cn/web/api/performanceobserver/observe/index.md
	renamed:    files/zh-cn/web/api/performanceobserver/performanceobserver/index.html -> files/zh-cn/web/api/performanceobserver/performanceobserver/index.md
	renamed:    files/zh-cn/web/api/performanceobserver/takerecords/index.html -> files/zh-cn/web/api/performanceobserver/takerecords/index.md
@fwqaaq
Copy link
Contributor Author

fwqaaq commented Aug 1, 2022

I don't know how to modify the first commit message? could you help me

https://docs.github.com/cn/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/changing-a-commit-message

It needs to checkout the commit. I don't expect its documentation to be so brief

@yin1999 yin1999 merged commit 50a698a into mdn:main Aug 1, 2022
@fwqaaq fwqaaq deleted the performanceObserver branch August 1, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-zh Issues related to Chinese content.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants