Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-translate the writing style guide for zh-CN (Part 2) #6511

Merged
merged 3 commits into from
Jun 27, 2022
Merged

Re-translate the writing style guide for zh-CN (Part 2) #6511

merged 3 commits into from
Jun 27, 2022

Conversation

awxiaoxian2020
Copy link
Contributor

@awxiaoxian2020 awxiaoxian2020 commented Jun 26, 2022

continue #6238 .

Todo:

  • convert to md
  • add translations

@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Jun 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2022

Preview URLs

Flaws

URL: /zh-CN/docs/MDN/Guidelines/Writing_style_guide
Title: MDN Web 文档写作规范
on GitHub
Flaw count: 5

  • macros:
    • /zh-CN/docs/Web/HTML/Element/h2 does not exist but fell back to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /zh-CN/docs/Web/HTML/Element/h3 does not exist but fell back to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /zh-CN/docs/Web/HTML/Element/h4 does not exist but fell back to /en-US/docs/Web/HTML/Element/Heading_Elements
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback

External URLs

URL: /zh-CN/docs/MDN/Guidelines/Writing_style_guide
Title: MDN Web 文档写作规范
on GitHub

(this comment was updated 2022-06-27 00:10:12.737697)

@awxiaoxian2020
Copy link
Contributor Author

@yin1999 Could you please help me to handle the unsupported dl elements?

 # Report from 2022/6/26 16:54:17
## All unhandled elements
- dl (12)
## Details per Document
### [/zh-CN/docs/MDN/Guidelines/Writing_style_guide](https://developer.mozilla.org/zh-CN/docs/MDN/Guidelines/Writing_style_guide)
### Missing conversion rules
- dl (326:1)
- dl (376:1)
- dl (389:1)
- dl (446:1)
- dl (457:1)
- dl (470:1)
- dl (483:1)
- dl (496:1)
- dl (511:1)
- dl (528:1)
- dl (543:1)
- dl (560:1)

@yin1999
Copy link
Member

yin1999 commented Jun 26, 2022

fixed, please using command git rebase to squash those two commits

@yin1999
Copy link
Member

yin1999 commented Jun 26, 2022

LGTM. Is it ready for merging?

@awxiaoxian2020
Copy link
Contributor Author

LGTM. Is it ready for merging?

I will add more translations when I'm available.

@yin1999
Copy link
Member

yin1999 commented Jun 26, 2022

I will add more translations when I'm available.

Ok, please do this in the last commit

@awxiaoxian2020 awxiaoxian2020 marked this pull request as ready for review June 26, 2022 14:01
@awxiaoxian2020 awxiaoxian2020 requested a review from a team as a code owner June 26, 2022 14:01
@awxiaoxian2020 awxiaoxian2020 requested review from yin1999 and removed request for a team June 26, 2022 14:01
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@yin1999 yin1999 merged commit 44370a9 into mdn:main Jun 27, 2022
@awxiaoxian2020 awxiaoxian2020 deleted the zh-doc branch June 27, 2022 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-zh Issues related to Chinese content.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants