Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ifmethod in alert page [es] #6357

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Remove ifmethod in alert page [es] #6357

merged 3 commits into from
Jun 23, 2022

Conversation

JuanVqz
Copy link
Member

@JuanVqz JuanVqz commented Jun 18, 2022

Related #6337
Closes #6338

@JuanVqz JuanVqz added the l10n-es Issues related to Spanish content. label Jun 18, 2022
@JuanVqz JuanVqz requested a review from a team as a code owner June 18, 2022 04:49
@JuanVqz JuanVqz self-assigned this Jun 18, 2022
@JuanVqz JuanVqz requested review from marcelozarate and removed request for a team June 18, 2022 04:49
@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2022

Preview URLs

Flaws

None! 🎉

External URLs

URL: /es/docs/Web/API/Window/alert
Title: Window.alert()
on GitHub

No new external URLs

(this comment was updated 2022-06-23 15:20:45.681001)

Copy link
Contributor

@Graywolf9 Graywolf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelente traducción, dejé algunos comentarios, muchas gracias!

Comment on lines 9 to 11
El método `Window.alert()` muestra un diálogo de alerta con opción de especificar contenido, aguardará hasta que el usuario cierre la ventana de diálogo.

## Sintaxis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Falta traducción

Suggested change
El método `Window.alert()` muestra un diálogo de alerta con opción de especificar contenido, aguardará hasta que el usuario cierre la ventana de diálogo.
## Sintaxis
El método `Window.alert()` muestra un diálogo de alerta con opción de especificar contenido, aguardará hasta que el usuario cierre la ventana de diálogo.
Under some conditions — for example, when the user switches tabs — the browser may not actually display a dialog, or may not wait for the user to dismiss the dialog.
## Sintaxis

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lo checo en la noche (espero)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resuelto! Gracias por la observación.

files/es/web/api/window/alert/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@marcelozarate marcelozarate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Excelente trabajo! Aprovechando una corrección menor para hacer una traducción completa y de calidad. ¡Gracias @JuanVqz!

files/es/web/api/window/alert/index.md Outdated Show resolved Hide resolved
files/es/web/api/window/alert/index.md Outdated Show resolved Hide resolved
files/es/web/api/window/alert/index.md Show resolved Hide resolved
files/es/web/api/window/alert/index.md Outdated Show resolved Hide resolved
files/es/web/api/window/alert/index.md Outdated Show resolved Hide resolved
files/es/web/api/window/alert/index.md Outdated Show resolved Hide resolved
files/es/web/api/window/alert/index.md Show resolved Hide resolved
Co-authored-by: Marcelo Zárate <[email protected]>
@JuanVqz
Copy link
Member Author

JuanVqz commented Jun 23, 2022

@marcelozarate @Graywolf9 agregue las sugerencias! Gracias

@marcelozarate marcelozarate merged commit 977026f into mdn:main Jun 23, 2022
@JuanVqz JuanVqz deleted the fix-ifmethod-alert-page-es branch June 23, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-es Issues related to Spanish content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

files/es/web/api/window/alert/index.html
3 participants