Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Element.closest() #5534

Merged
merged 3 commits into from
May 11, 2022
Merged

Conversation

alattalatta
Copy link
Member

  • Markdown
    • 스쿼시 병합 하지 말아주세요.
  • 재작성

mdn/mdn-community#64

@alattalatta alattalatta requested a review from a team as a code owner May 10, 2022 09:05
@alattalatta alattalatta requested review from hochan222 and removed request for a team May 10, 2022 09:05
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label May 10, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /ko/docs/Web/API/Element/closest
Title: Element.closest()
on GitHub
Flaw count: 4

  • macros:
    • /ko/docs/Web/API/DOMException does not exist but fell back to /en-US/docs/Web/API/DOMException
    • /ko/docs/Web/API/Element/querySelector does not exist but fell back to /en-US/docs/Web/API/Element/querySelector
    • /ko/docs/Web/API/Element/querySelectorAll does not exist but fell back to /en-US/docs/Web/API/Element/querySelectorAll
    • /ko/docs/Web/API/Element/matches does not exist but fell back to /en-US/docs/Web/API/Element/matches

External URLs

URL: /ko/docs/Web/API/Element/closest
Title: Element.closest()
on GitHub

No new external URLs

@hochan222
Copy link
Member

hochan222 commented May 11, 2022

@alattalatta 님, 안녕하세요 :)

#5569 Discussions이라서.. PR 추적이 안되었네요..!

혹시 다른 반영사항있다면 해당 Discussions에 mdn/mdn-community#64 (comment) 처럼 남겨주실 수 있으신가요?

Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@hochan222 hochan222 merged commit 09e5175 into mdn:main May 11, 2022
@alattalatta
Copy link
Member Author

@alattalatta 님, 안녕하세요 :)

#5569 Discussions이라서.. PR 추적이 안되었네요..!

혹시 다른 반영사항있다면 해당 Discussions에 mdn/mdn-community#64 (comment) 처럼 남겨주실 수 있으신가요?

앗... 그렇네요. 병합되고 댓글을 달게 아니라 PR 발행하면 달아야 맞겠군요. 괜한 수고 하셨네요. 죄송합니다 😭

@alattalatta alattalatta deleted the api/element/closest branch May 11, 2022 15:59
@hochan222
Copy link
Member

아닙니다 ㅎㅎ 답변주셔서 감사합니다. 좋은 밤 보내세요 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants