Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ko prepare h2m #4242

Merged
merged 6 commits into from
Mar 16, 2022
Merged

Ko prepare h2m #4242

merged 6 commits into from
Mar 16, 2022

Conversation

SnowMarble
Copy link
Contributor

#2894 인라인 스타일 제거와 blockIndicator 클래스를 제거했습니다.

이제 변환을 시작해도 괜찮은 단계라고 생각되네요 🦴

@SnowMarble SnowMarble requested a review from a team as a code owner February 22, 2022 01:55
@SnowMarble SnowMarble requested review from cos18 and removed request for a team February 22, 2022 01:56
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Feb 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2022 •
edited
Loading

Preview URLs

Flaws

URL: /ko/docs/Web/JavaScript/Language_Resources
Title: 자바스크립트 언어 자료
on GitHub
Flaw count: 20

  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Can't resolve /en-US/docs/JavaScript/ECMAScript_5_support_in_Mozilla
    • and 15 more flaws omitted

URL: /ko/docs/Web/JavaScript/Typed_arrays
Title: JavaScript 형식화 배열
on GitHub
Flaw count: 24

  • macros:
    • /ko/docs/Web/JavaScript/Reference/Uint8Array does not exist
    • /ko/docs/Web/JavaScript/Reference/Uint8ClampedArray does not exist
    • /ko/docs/Web/JavaScript/Reference/Int16Array does not exist
    • /ko/docs/Web/JavaScript/Reference/Uint16Array does not exist
    • /ko/docs/Web/JavaScript/Reference/Int32Array does not exist
    • and 10 more flaws omitted
  • images:
    • External image URL
  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase
    • Can't resolve /ko/docs/Web/WebGL
    • Can't resolve /ko/docs/Mozilla/js-ctypes
    • Can use the English (en-US) link as a fallback
    • and 2 more flaws omitted
  • translation_differences:
    • Differences in the important macros (1 in common of 2 possible)

URL: /ko/docs/Web/JavaScript/Reference/Statements/debugger
Title: debugger
on GitHub
Flaw count: 4

  • images:
    • External image URL
  • broken_links:
    • Can't resolve /ko/docs/Mozilla/Debugging/Debugging_JavaScript
    • Can't resolve /ko/docs/도구들/Debugger
  • translation_differences:
    • Differences in the important macros (1 in common of 4 possible)

URL: /ko/docs/Web/JavaScript/Guide/Details_of_the_Object_Model
Title: 객체 모델의 세부 사항
on GitHub
Flaw count: 8

  • images:
    • External image URL
    • External image URL
    • External image URL
    • External image URL
    • External image URL
  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase

URL: /ko/docs/Web/JavaScript/Guide/Control_flow_and_error_handling
Title: 제어 흐름과 에러 처리
on GitHub
Flaw count: 8

  • macros:
    • /ko/docs/Web/API/DOMException does not exist but fell back to /en-US/docs/Web/API/DOMException
    • /ko/docs/Web/API/DOMError does not exist but fell back to /en-US/docs/Web/API/DOMError
  • images:
    • External image URL
  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase
    • Can't resolve https://developer.mozilla.org/ko/docs/Web/JavaScript/Reference/Statements/try...catch
    • Can't resolve https://developer.mozilla.org/ko/docs/Web/JavaScript/Reference/Statements/try...catch#Nested_try-blocks
    • Is currently http:// but can become https://

URL: /ko/docs/Web/JavaScript/Guide/Indexed_collections
Title: Indexed collections
on GitHub
Flaw count: 10

  • macros:
    • /ko/docs/Web/JavaScript/Reference/Statements%20/%20for%20...%20in does not exist
    • /ko/docs/Web/JavaScript/Reference/Global_Objects%20/%20RegExp%20/%20exec does not exist
    • /ko/docs/Web/API/Document/getElementsByTagName_ does not exist
    • /ko/docs/Web/JavaScript/Reference/Functions%20/%20arguments does not exist
    • /ko/docs/Web/JavaScript/Reference/Global_Objects%20/%20Function%20/%20length does not exist
  • images:
    • External image URL
  • broken_links:
    • Anchor not lowercase
    • Can't resolve https://developer.mozilla.org/en-US/docs/DOM
    • Can't resolve /en-US/docs/WebSockets
  • translation_differences:
    • Differences in the important macros (1 in common of 2 possible)

URL: /ko/docs/Web/JavaScript/Guide/Introduction
Title: Introduction
on GitHub
Flaw count: 9

  • macros:
    • /ko/docs/Glossary/WWW does not exist but fell back to /en-US/docs/Glossary/World_Wide_Web
  • images:
    • External image URL
    • External image URL
  • broken_links:
    • Can't resolve /ko/docs/Web/JavaScript/Guide/객체_모델의_세부사항
    • Is currently http:// but can become https://
    • Can't resolve /ko/docs/Web/JavaScript/New_in_JavaScript
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • and 1 more flaws omitted

External URLs

URL: /ko/docs/Web/JavaScript/Language_Resources
Title: 자바스크립트 언어 자료
on GitHub

URL: /ko/docs/Web/JavaScript/Typed_arrays
Title: JavaScript 형식화 배열
on GitHub

No new external URLs

URL: /ko/docs/Web/JavaScript/Reference/Statements/debugger
Title: debugger
on GitHub

URL: /ko/docs/Web/JavaScript/Guide/Details_of_the_Object_Model
Title: 객체 모델의 세부 사항
on GitHub

No new external URLs

URL: /ko/docs/Web/JavaScript/Guide/Control_flow_and_error_handling
Title: 제어 흐름과 에러 처리
on GitHub

No new external URLs

URL: /ko/docs/Web/JavaScript/Guide/Indexed_collections
Title: Indexed collections
on GitHub

No new external URLs

URL: /ko/docs/Web/JavaScript/Guide/Introduction
Title: Introduction
on GitHub

No new external URLs

(this comment was updated 2022-03-11 23:51:53.415759)

cos18
cos18 reviewed Mar 11, 2022
View reviewed changes
Copy link
Collaborator

@cos18 cos18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR을 늦게 확인해 죄송합니다. 기여 내용에는 이상이 없으나 그 사이에 files/ko/web/javascript/guide/regular_expressions 의 내용이 마크다운으로 변경되어 해당 파일들을 PR에서 제거해야 합니다. 혹시 해당 작업이 어려우시다면 현 PR을 close 하고 새로운 브랜치 & PR을 새로 열어 저를 태그해주시면 바로 리뷰 드리겠습니다.

@SnowMarble
Copy link
Contributor Author

@cos18 수정했습니다.

@SnowMarble
Copy link
Contributor Author

@hochan222 할당된 리뷰가 아닌데 멘션해서 죄송합니다.😓 현재 리뷰가 진행되고 있지아 또 다른 pr로 충돌이 생길까 걱정되네요. 괜찮으시다면 확인 부탁드립니다.

@cos18 cos18 self-requested a review March 16, 2022 11:06
cos18
cos18 approved these changes Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@cos18 cos18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

늦게 확인해 죄송합니다. 이후 pr에서는 최대한 빠르게 리뷰 드리겠습니다. 기여 감사드립니다!
LGTM 👍

@cos18 cos18 merged commit 0c715c2 into mdn:main Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cos18 cos18 cos18 approved these changes

Assignees
No one assigned
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SnowMarble @cos18