Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove DOMAttributeMethods deprecated macro #23462

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

hochan222
Copy link
Member

@hochan222 hochan222 commented Sep 8, 2024

Description

remove DOMAttributeMethods deprecated macro

Motivation

yarn tool macro-usage-report --deprecated-only

macro yari en-us es fr ja ko pt-br ru zh-cn zh-tw
CSSAnimatedProperties 🗑 - - - 1 - - - - - -
DOMAttributeMethods 🗑 - - 3 - 13 1 - - - -
event 🗑 - - - - - - 76 125 - -
no_tag_omission 🗑 - - 27 29 - 58 32 49 - -
page 🗑 - - - - - - 47 - - -
unimplemented_inline 🗑 - - - - - - - - - -

Additional details

Related issues and pull requests

@hochan222 hochan222 requested review from a team as code owners September 8, 2024 02:18
@hochan222 hochan222 requested review from 1ilsang, JuanVqz and mfuji09 and removed request for a team September 8, 2024 02:18
@github-actions github-actions bot added l10n-ja Issues related to Japanese content. l10n-es Issues related to Spanish content. l10n-ko Issues related to Korean content. labels Sep 8, 2024
Copy link
Contributor

github-actions bot commented Sep 8, 2024

Preview URLs (17 pages)
Flaws (8)

Note! 12 documents with no flaws that don't need to be listed. 🎉

URL: /es/docs/Web/API/Element/removeAttribute
Title: Element.removeAttribute()
Flaw count: 2

  • broken_links:
    • Can't resolve /en/DOM/element.setAttribute
  • translation_differences:
    • Differences in the important macros (2 in common of 4 possible)

URL: /es/docs/Web/API/Element/getAttributeNodeNS
Title: Element.getAttributeNodeNS()
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (2 in common of 4 possible)

URL: /es/docs/Web/API/Element/setAttributeNS
Title: Element.setAttributeNS()
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (2 in common of 4 possible)

URL: /ja/docs/Web/API/Element/getAttributeNS
Title: Element: getAttributeNS() メソッド
Flaw count: 1

  • broken_links:
    • Can't resolve /ja/docs/Mozilla/Add-ons/Code_snippets/getAttributeNS

URL: /ko/docs/Web/API/Element/setAttribute
Title: Element.setAttribute()
Flaw count: 3

  • macros:
    • /ko/docs/Web/API/Element/getAttribute does not exist but fell back to /en-US/docs/Web/API/Element/getAttribute
    • /ko/docs/Web/API/DOMException does not exist but fell back to /en-US/docs/Web/API/DOMException
  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)
External URLs (8)

URL: /ja/docs/Web/API/Element/setAttribute
Title: Element: setAttribute() メソッド


URL: /ko/docs/Web/API/Element/setAttribute
Title: Element.setAttribute()

Copy link
Member

@1ilsang 1ilsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Japanese contents!
Thank you!

Copy link
Contributor

@Graywolf9 Graywolf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for es

Thank you so much!

@Graywolf9 Graywolf9 removed the request for review from JuanVqz September 10, 2024 22:29
@hochan222 hochan222 merged commit fe37baf into mdn:main Sep 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-es Issues related to Spanish content. l10n-ja Issues related to Japanese content. l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants