Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zh-cn): deal with macro render problems #13623

Merged
merged 3 commits into from
Jun 8, 2023
Merged

fix(zh-cn): deal with macro render problems #13623

merged 3 commits into from
Jun 8, 2023

Conversation

jasonren0403
Copy link
Contributor

Description

fix unrendered macro occurences

Related issues and pull requests

Part of #13499

@jasonren0403 jasonren0403 requested a review from a team as a code owner June 8, 2023 02:28
@jasonren0403 jasonren0403 requested review from t7yang and removed request for a team June 8, 2023 02:28
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Jun 8, 2023
@jasonren0403 jasonren0403 requested review from yin1999 and removed request for t7yang June 8, 2023 02:29
jasonren0403
jasonren0403 commented Jun 8, 2023
View reviewed changes
files/zh-cn/web/css/css_functions/index.md Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needs a complete retranslate, the content seems to have rewritten.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023 •
edited
Loading

Preview URLs (17 pages)
Flaws (101)

Note! 6 documents with no flaws that don't need to be listed. 🎉

URL: /zh-CN/docs/Web/CSS/Using_CSS_custom_properties
Title: 使用 CSS 自定义属性（变量）
Flaw count: 3

  • macros:
    • /zh-CN/docs/Web/CSS/var() redirects to /zh-CN/docs/Web/CSS/var
    • /zh-CN/docs/Web/CSS/var() redirects to /zh-CN/docs/Web/CSS/var
  • translation_differences:
    • Differences in the important macros (1 in common of 6 possible)

URL: /zh-CN/docs/Web/CSS/CSS_box_model/Mastering_margin_collapsing
Title: 外边距重叠
Flaw count: 3

  • broken_links:
    • Can't resolve /zh-CN/docs/Web/CSS/inheritance
    • Link points to the page it's already on
  • translation_differences:
    • Differences in the important macros (1 in common of 3 possible)

URL: /zh-CN/docs/Web/CSS/CSS_box_model/Introduction_to_the_CSS_box_model
Title: CSS 基础框盒模型介绍
Flaw count: 4

  • broken_links:
    • Can't resolve /zh-CN/CSS/margin_collapsing
    • Can't resolve /zh-CN/docs/Learn/CSS/Introduction_to_CSS/Cascade_and_inheritance
    • Can't resolve /zh-CN/docs/Web/CSS/inheritance
    • Link points to the page it's already on

URL: /zh-CN/docs/Web/CSS/CSS_Functions
Title: CSS Functional Notation
Flaw count: 53

  • macros:
    • /zh-CN/docs/Web/CSS/abs does not exist but fell back to /en-US/docs/Web/CSS/abs
    • /zh-CN/docs/Web/CSS/font-variant-alternates/annotation() does not exist
    • /zh-CN/docs/Web/CSS/font-variant-alternates/character-variant() does not exist
    • /zh-CN/docs/Web/CSS/circle does not exist
    • /zh-CN/docs/Web/CSS/color() does not exist
    • and 47 more flaws omitted
  • broken_links:
    • Can't resolve /zh-CN/docs/Learn/CSS/Introduction_to_CSS/Values_and_units

URL: /zh-CN/docs/Web/CSS/CSS_colors
Title: CSS Color
Flaw count: 7

  • macros:
    • /zh-CN/docs/Web/CSS/color-adjust does not exist but fell back to /en-US/docs/Web/CSS/print-color-adjust
    • /zh-CN/docs/Web/CSS/print-color-adjust does not exist but fell back to /en-US/docs/Web/CSS/print-color-adjust
  • broken_links:
    • Can't resolve /zh-CN/docs/Web/HTML/Applying_color
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (2 in common of 3 possible)

URL: /zh-CN/docs/Web/CSS/CSS_media_queries
Title: 媒体查询
Flaw count: 2

  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can't resolve /zh-CN/docs/Web/CSS/CSS_media_queries/Using_CSS_media_queries_for_Accessibility

URL: /zh-CN/docs/Web/API/Fetch_API/Using_Fetch
Title: 使用 Fetch
Flaw count: 4

  • macros:
    • /zh-CN/docs/Web/API/Response/error redirects to /zh-CN/docs/Web/API/Response/error_static
    • /zh-CN/docs/Web/API/Response/redirect redirects to /zh-CN/docs/Web/API/Response/redirect_static
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Anchor not lowercase

URL: /zh-CN/docs/Web/API/Web_Animations_API/Keyframe_Formats
Title: 关键帧格式
Flaw count: 5

  • macros:
    • /zh-CN/docs/Web/API/KeyframeEffect/setKeyframes does not exist but fell back to /en-US/docs/Web/API/KeyframeEffect/setKeyframes
    • /zh-CN/docs/Web/API/KeyframeEffect/getKeyframes does not exist but fell back to /en-US/docs/Web/API/KeyframeEffect/getKeyframes
    • /zh-CN/docs/Web/API/KeyframeEffect/composite does not exist but fell back to /en-US/docs/Web/API/KeyframeEffect/composite
    • /zh-CN/docs/Web/API/KeyframeEffect/setKeyframes does not exist but fell back to /en-US/docs/Web/API/KeyframeEffect/setKeyframes
  • broken_links:
    • Can use the English (en-US) link as a fallback

URL: /zh-CN/docs/Web/SVG/Attribute/max
Title: max
Flaw count: 3

  • macros:
    • /zh-CN/docs/Web/SVG/Element/animateColor redirects to /zh-CN/docs/Web/SVG/Element/animate
  • broken_links:
    • Anchor not lowercase
  • translation_differences:
    • Differences in the important macros (2 in common of 4 possible)

URL: /zh-CN/docs/Web/HTML/Element/menuitem
Title: <menuitem>
Flaw count: 16

  • macros:
    • /zh-CN/docs/Web/HTML/Attributes/accept does not exist but fell back to /en-US/docs/Web/HTML/Attributes/accept
    • /zh-CN/docs/Web/HTML/Attributes/capture does not exist but fell back to /en-US/docs/Web/HTML/Attributes/capture
    • /zh-CN/docs/Web/HTML/Attributes/elementtiming does not exist but fell back to /en-US/docs/Web/HTML/Attributes/elementtiming
    • /zh-CN/docs/Web/HTML/Attributes/for does not exist but fell back to /en-US/docs/Web/HTML/Attributes/for
    • /zh-CN/docs/Web/HTML/Attributes/max does not exist but fell back to /en-US/docs/Web/HTML/Attributes/max
    • and 10 more flaws omitted
  • translation_differences:
    • Differences in the important macros (1 in common of 3 possible)

URL: /zh-CN/docs/Web/HTTP/Headers/Accept-Patch
Title: Accept-Patch
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://
External URLs (3)

URL: /zh-CN/docs/Web/CSS/Using_CSS_custom_properties
Title: 使用 CSS 自定义属性（变量）

URL: /zh-CN/docs/Web/HTML/Element/menuitem
Title: <menuitem>

URL: /zh-CN/docs/Web/HTTP/Headers/Accept-Charset
Title: Accept-Charset

(comment last updated: 2023-06-08 03:20:33)

jasonren0403
jasonren0403 commented Jun 8, 2023
View reviewed changes
files/zh-cn/web/http/headers/accept-charset/index.md
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we have other occurences of 'old spec style' like this in zh-CN documents

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done the convertion while converting all html files to markdown. So there might be some occurences of this, but should not be too many, just remove when got one ;)

yin1999
yin1999 approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, just some fixes

files/zh-cn/web/css/css_colors/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/http/headers/accept-charset/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/http/headers/accept-charset/index.md Outdated Show resolved Hide resolved
@yin1999 yin1999 merged commit 93f49db into mdn:main Jun 8, 2023
@jasonren0403 jasonren0403 deleted the chore-zhcn-macro branch June 8, 2023 03:20
@jasonren0403 jasonren0403 mentioned this pull request Jun 8, 2023
Open
Lou8is pushed a commit to Lou8is/translated-content that referenced this pull request Jun 8, 2023
@jasonren0403 @yin1999 @Lou8is
fix(zh-cn): deal with macro render problems (mdn#13623)
bcebc17 
Co-authored-by: A1lo <[email protected]>
Lou8is pushed a commit to Lou8is/translated-content that referenced this pull request Jun 8, 2023
@jasonren0403 @yin1999 @Lou8is
fix(zh-cn): deal with macro render problems (mdn#13623)
1fbe6a5 
Co-authored-by: A1lo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 approved these changes

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonren0403 @yin1999