Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn] sync translated content #13204

Merged
merged 2 commits into from
May 11, 2023
Merged

[zh-cn] sync translated content #13204

merged 2 commits into from
May 11, 2023

Conversation

mdn-bot
Copy link
Collaborator

@mdn-bot mdn-bot commented May 11, 2023

Yari generated sync

@mdn-bot mdn-bot requested a review from a team as a code owner May 11, 2023 00:15
@mdn-bot mdn-bot requested review from yin1999 and removed request for a team May 11, 2023 00:15
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label May 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023 •
edited
Loading

Preview URLs (11 pages)
Flaws (146)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /zh-CN/docs/Web/Text_fragments
Title: 文本片段
Flaw count: 6

  • macros:
    • /zh-CN/docs/Web/API/FragmentDirective does not exist but fell back to /en-US/docs/Web/API/FragmentDirective
    • /zh-CN/docs/Web/API/Document/fragmentDirective does not exist but fell back to /en-US/docs/Web/API/Document/fragmentDirective
    • /zh-CN/docs/Web/API/FragmentDirective does not exist but fell back to /en-US/docs/Web/API/FragmentDirective
    • /zh-CN/docs/Web/API/FragmentDirective does not exist but fell back to /en-US/docs/Web/API/FragmentDirective
    • /zh-CN/docs/Web/API/Document/fragmentDirective does not exist but fell back to /en-US/docs/Web/API/Document/fragmentDirective
    • and 1 more flaws omitted

URL: /zh-CN/docs/Web/CSS/Containing_block
Title: 布局和包含块
Flaw count: 1

  • broken_links:
    • Can't resolve /zh-CN/docs/Web/CSS/inheritance

URL: /zh-CN/docs/Web/CSS/vertical-align
Title: vertical-align
Flaw count: 3

  • broken_links:
    • Can't resolve /zh-CN/docs/CSS
    • Anchor not lowercase
  • translation_differences:
    • Differences in the important macros (5 in common of 9 possible)

URL: /zh-CN/docs/Web/CSS/column-span
Title: column-span
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (5 in common of 7 possible)

URL: /zh-CN/docs/Web/HTML
Title: HTML（超文本标记语言）
Flaw count: 18

  • macros:
    • /zh-CN/docs/Web/HTML/Attributes/accept does not exist but fell back to /en-US/docs/Web/HTML/Attributes/accept
    • /zh-CN/docs/Web/HTML/Attributes/capture does not exist but fell back to /en-US/docs/Web/HTML/Attributes/capture
    • /zh-CN/docs/Web/HTML/Attributes/elementtiming does not exist but fell back to /en-US/docs/Web/HTML/Attributes/elementtiming
    • /zh-CN/docs/Web/HTML/Attributes/for does not exist but fell back to /en-US/docs/Web/HTML/Attributes/for
    • /zh-CN/docs/Web/HTML/Attributes/max does not exist but fell back to /en-US/docs/Web/HTML/Attributes/max
    • and 8 more flaws omitted
  • broken_links:
    • Can't resolve /zh-CN/docs/Learn/HTML/Forms
    • Can't resolve /zh-CN/docs/Web/HTML/Link_types/preload
    • Can't resolve /zh-CN/docs/Web/HTML/Link_types
    • Can't resolve /zh-CN/docs/Web/HTML/Link_types
    • Can't resolve /zh-CN/docs/Web/Guide/HTML/Content_categories

URL: /zh-CN/docs/Web/HTML/Element
Title: HTML 元素参考
Flaw count: 18

  • macros:
    • /zh-CN/docs/Web/HTML/Attributes/accept does not exist but fell back to /en-US/docs/Web/HTML/Attributes/accept
    • /zh-CN/docs/Web/HTML/Attributes/capture does not exist but fell back to /en-US/docs/Web/HTML/Attributes/capture
    • /zh-CN/docs/Web/HTML/Attributes/elementtiming does not exist but fell back to /en-US/docs/Web/HTML/Attributes/elementtiming
    • /zh-CN/docs/Web/HTML/Attributes/for does not exist but fell back to /en-US/docs/Web/HTML/Attributes/for
    • /zh-CN/docs/Web/HTML/Attributes/max does not exist but fell back to /en-US/docs/Web/HTML/Attributes/max
    • and 12 more flaws omitted
  • translation_differences:
    • Differences in the important macros (0 in common of 2 possible)

URL: /zh-CN/docs/Learn/CSS/CSS_layout/Normal_Flow
Title: 正常布局流
Flaw count: 36

  • macros:
    • /zh-CN/docs/Learn/CSS/Building_blocks/Cascade_layers does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Cascade_layers
    • /zh-CN/docs/Learn/Forms/UI_pseudo-classes does not exist but fell back to /en-US/docs/Learn/Forms/UI_pseudo-classes
    • /zh-CN/docs/Learn/Performance/Multimedia does not exist but fell back to /en-US/docs/Learn/Performance/Multimedia
    • /zh-CN/docs/Learn/Performance/video does not exist but fell back to /en-US/docs/Learn/Performance/video
    • /zh-CN/docs/Learn/Performance/JavaScript does not exist but fell back to /en-US/docs/Learn/Performance/JavaScript
    • and 30 more flaws omitted
  • translation_differences:
    • Differences in the important macros (1 in common of 3 possible)

URL: /zh-CN/docs/Learn/HTML/Introduction_to_HTML/Getting_started
Title: 开始学习 HTML
Flaw count: 36

  • macros:
    • /zh-CN/docs/Learn/CSS/Building_blocks/Cascade_layers does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Cascade_layers
    • /zh-CN/docs/Learn/Forms/UI_pseudo-classes does not exist but fell back to /en-US/docs/Learn/Forms/UI_pseudo-classes
    • /zh-CN/docs/Learn/Performance/Multimedia does not exist but fell back to /en-US/docs/Learn/Performance/Multimedia
    • /zh-CN/docs/Learn/Performance/video does not exist but fell back to /en-US/docs/Learn/Performance/video
    • /zh-CN/docs/Learn/Performance/JavaScript does not exist but fell back to /en-US/docs/Learn/Performance/JavaScript
    • and 30 more flaws omitted
  • translation_differences:
    • Differences in the important macros (1 in common of 18 possible)

URL: /zh-CN/docs/Glossary/Block-level_content
Title: 块级元素
Flaw count: 10

  • macros:
    • /zh-CN/docs/Web/HTML/Element/h1 does not exist but fell back to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /zh-CN/docs/Web/HTML/Element/h2 does not exist but fell back to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /zh-CN/docs/Web/HTML/Element/h3 does not exist but fell back to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /zh-CN/docs/Web/HTML/Element/h4 does not exist but fell back to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /zh-CN/docs/Web/HTML/Element/h5 does not exist but fell back to /en-US/docs/Web/HTML/Element/Heading_Elements
    • and 1 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (0 in common of 2 possible)

URL: /zh-CN/docs/Glossary/Inline-level_content
Title: 行级元素
Flaw count: 17

  • macros:
    • /zh-CN/docs/Web/HTML/Attributes/accept does not exist but fell back to /en-US/docs/Web/HTML/Attributes/accept
    • /zh-CN/docs/Web/HTML/Attributes/capture does not exist but fell back to /en-US/docs/Web/HTML/Attributes/capture
    • /zh-CN/docs/Web/HTML/Attributes/elementtiming does not exist but fell back to /en-US/docs/Web/HTML/Attributes/elementtiming
    • /zh-CN/docs/Web/HTML/Attributes/for does not exist but fell back to /en-US/docs/Web/HTML/Attributes/for
    • /zh-CN/docs/Web/HTML/Attributes/max does not exist but fell back to /en-US/docs/Web/HTML/Attributes/max
    • and 8 more flaws omitted
  • broken_links:
    • Can't resolve /zh-CN/docs/Web/HTML/Element/Img
    • Can't resolve /zh-CN/docs/Web/HTML/Element/Script
    • Can't resolve /zh-CN/docs/Web/HTML/Element/Input
  • translation_differences:
    • Differences in the important macros (0 in common of 3 possible)

(comment last updated: 2023-05-11 02:38:31)

@fwqaaq
Copy link
Contributor

fwqaaq commented May 11, 2023 •
edited
Loading

Maybe the bot has a lot of problems about CSS block-level and inline-level, it may have to have a huge update.

@yin1999
Copy link
Member

yin1999 commented May 11, 2023

Maybe the bot has a lot of problems about CSS block-level and inline-level, it may have to have a huge update.

Could you tell the details about the "problem"?

@fwqaaq
Copy link
Contributor

fwqaaq commented May 11, 2023

Elements, according to the HTML 4 specification, used to be either block-level or inline. That was it. No other categories i don't think. The new specification uses neither inline not inline-level. Rather, it uses content models, https://html.spec.whatwg.org/#kinds-of-content.

I mean its content should be updated. The bot just copied it.

@yin1999
Copy link
Member

yin1999 commented May 11, 2023

I mean its content should be updated. The bot just copied it.

Hi @fwqaaq. This tool is used to move documents (resolve redirects only). It might be an good idea about updating the content we have in translated-content. But I think it's a bit difficult, as we should leave translated content here.

But this means we need to use some APIs (such as google translation, etc.) to update the translation here. I thinks it's not really realistic, as the documents that need to be moved are not necessarily consistent with the content of the English documents before. So what bot could do is limited in resolving redirects (update old links, this should be a feature we could added in mdn/yari) and move documents.

@yin1999 yin1999 merged commit 5170b17 into main May 11, 2023
@yin1999 yin1999 deleted the content-sync-zh-cn branch May 11, 2023 04:10
@fwqaaq
Copy link
Contributor

fwqaaq commented May 11, 2023 •
edited
Loading

Yeah, but the bot behavior is strange, the two docs don't seem to have anything to do with each other, and it moved old doc to new doc :)

For example: https://github.com/mdn/translated-content/pull/13204/files#diff-0a88160b658eb3b7a4cea24d12a41e490dc13c117afbd5391900c94878c0b63c

@yin1999
Copy link
Member

yin1999 commented May 11, 2023

Yeah, but the bot behavior is strange, the two docs don't seem to have anything to do with each other, and it moved old doc to new doc :)

For example: https://github.com/mdn/translated-content/pull/13204/files#diff-0a88160b658eb3b7a4cea24d12a41e490dc13c117afbd5391900c94878c0b63c

No. Actually, git does not support move a content, that is git mv just delete the old file and create a new one. GitHub would check the content changes to figure whether a file is moved or deleted. So, I think the changes listed in this PR is correct.

@fwqaaq
Copy link
Contributor

fwqaaq commented May 11, 2023

No. Actually, git does not support move a content, that is git mv just delete the old file and create a new one. GitHub would check the content changes to figure whether a file is moved or deleted. So, I think the changes listed in this PR is correct.

Yeah, I agree with what you said. If it's entirely new content, I believe it shouldn't be moved.

@yin1999
Copy link
Member

yin1999 commented May 11, 2023

Yes, this should be a new content. But the bot would not know that. And actually, this movement is made in 329fd52 to performance URL redirect in _redirect.txt

@fwqaaq
Copy link
Contributor

fwqaaq commented May 11, 2023

I reckon it could use a little tweaking, perhaps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 approved these changes

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdn-bot @fwqaaq @yin1999