-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove WindowOrWorkerGlobalScope [es] #11275
Remove WindowOrWorkerGlobalScope [es] #11275
Conversation
Preview URLs (10 pages)
Flaws (262)URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
External URLs (1)URL:
(comment last updated: 2023-01-27 17:40:18) |
@@ -1,12 +1,12 @@ | |||
--- | |||
title: WindowOrWorkerGlobalScope.indexedDB | |||
title: indexedDB | |||
slug: Web/API/indexedDB | |||
original_slug: Web/API/WindowOrWorkerGlobalScope/indexedDB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @Graywolf9 thanks for contributing, should the original slug still calling the window or worker global scope?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review! I had the same doubt but there is other issue about the front matter keys that says that it is a front matter added from Yari so it updates as necessary for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but even that didn't you think we should remove it to avoid confusion in possible next reviews?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aquí hay un ejemplo de como Yari en sus rutinas modifica ese slug, esta en: #11525
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, approved!
Description
Remove WindowOrWorkerGlobalScope page and mentions for
es
Steps:
Web/API/WindowOrWorkerGlobalScope
WindowOrWorkerGlobalScope.
-- for each page:yarn content move Web/API/WindowOrWorkerGlobalScope/<prop> Web/API/<prop> <locale>
inmdn-content
(already moved)WindowOrWorkerGlobalScope.caches
becomescaches
)translation_of
key to remove mention (AKA,Web/API/WindowOrWorkerGlobalScope/caches
becomesWeb/API/caches
) (there wasn't)browser-compat
key to remove mention (AKA,api.WindowOrWorkerGlobalScope.caches
becomesapi.caches
) (there wasn't)browser-compat
key, but there is a{{Compat}}
macro, update its value insteadbrowser-compat
key or{{Compat}}
macro call exist, ignore this step{{domxref}}
references toWindowOrWorkerGlobalScope
(the regexdomxref[ ]*\([ ]*["'][ ]*WindowOrWorkerGlobalScope
may help find these instances)Motivation
Fix an issue
Additional details
Related issues and pull requests
Relates to #5617