Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove {{TemplateLink}} macro #10348

Merged
merged 3 commits into from
Dec 1, 2022
Merged

chore: remove {{TemplateLink}} macro #10348

merged 3 commits into from
Dec 1, 2022

Conversation

MrBrain295
Copy link
Contributor

Description

Remove the {{TemplateLink}} macro.

Motivation

Its deprecated.

Additional details

Related issues and pull requests

#5603

@MrBrain295 MrBrain295 requested review from a team as code owners November 30, 2022 20:56
@MrBrain295 MrBrain295 requested review from lex111 and clovislima and removed request for a team November 30, 2022 20:56
@github-actions github-actions bot added l10n-pt-br Issues related to Brazilian Portuguese l10n-ru Issues related to Russian content. labels Nov 30, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws (41)

URL: /pt-BR/docs/MDN/Writing_guidelines/Writing_style_guide
Title: Guia de estilo de escrita
Flaw count: 27

  • macros:
    • /pt-BR/docs/Web/HTML/Element/h2 does not exist but fell back to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /pt-BR/docs/Web/HTML/Element/h3 does not exist but fell back to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /pt-BR/docs/Web/HTML/Element/h4 does not exist but fell back to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /pt-BR/docs/Web/HTML/Element/h2 does not exist but fell back to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /pt-BR/docs/Web/HTML/Element/h1 does not exist but fell back to /en-US/docs/Web/HTML/Element/Heading_Elements
    • and 6 more flaws omitted
  • broken_links:
    • Can't resolve /pt-BR/docs/MDN/Contribute/Content/Layout
    • Is currently http:// but can become https://
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • and 11 more flaws omitted

URL: /pt-BR/docs/conflicting/MDN/Writing_guidelines/Page_structures/Live_samples
Title: Como criar um exercício de aprendizado interativo
Flaw count: 6

  • macros:
    • The fourth to sixth parameters of 'EmbedLiveSample' are deprecated
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Anchor not lowercase
    • Can't resolve /pt-BR/docs/MDN/Contribute/Editor/Source_mode
    • Can't resolve /pt-BR/docs/MDN/Contribute/Howto/Create_an_interactive_exercise_to_help_learning_the_web/distant_example
    • Can't resolve /pt-BR/docs/Web/Guide/HTML/Forms/How_to_build_custom_form_widgets

URL: /ru/docs/conflicting/MDN/Writing_guidelines/Page_structures/Live_samples
Title: Как создать интерактивное обучающее упражнение
Flaw count: 8

  • macros:
    • This macro has been deprecated, and should be removed.
    • This macro has been deprecated, and should be removed.
    • The fourth to sixth parameters of 'EmbedLiveSample' are deprecated
  • broken_links:
    • Can't resolve /en-US/docs/MDN/Contribute/Editor/Live_samples
    • Anchor not lowercase
    • Can't resolve /en-US/docs/MDN/Contribute/Editor/Source_mode
    • Can't resolve /en-US/docs/MDN/Contribute/Howto/Create_an_interactive_exercise_to_help_learning_the_web/distant_example
    • Can't resolve /en-US/docs/Web/Guide/HTML/Forms/How_to_build_custom_form_widgets

@sashasushko sashasushko changed the title Remove the {{TemplateLink}} macro chore: remove {{TemplateLink}} macro Nov 30, 2022
Copy link
Member

@sashasushko sashasushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve from @mdn/yari-content-ru

Copy link
Collaborator

@josielrocha josielrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cw118
Copy link
Member

cw118 commented Dec 1, 2022

Merging since it seems that both review teams have approved. Thanks very much @MrBrain295 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-pt-br Issues related to Brazilian Portuguese l10n-ru Issues related to Russian content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants