-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use reserved values for phone numbers and domains where possible #2650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using example.com
, http://example.com/
, @example.com
for examples is generally a good idea, especially in the case of emails. That said, URLs that give contextual support (or provide entertainment without being promotional) shouldn’t be replaced.
Also, good catch on the phone number. TIL: "The North American Numbering Plan reserves 555-01 numbers for fictitious purposes. "
Yeah I think this makes sense, I've reverted most of the wiki links, but I agree, with emails and telephone numbers, we should use reserved values. I presume it's also important what the example is doing (fetch or others that are actually making requests should only use example.com, I guess.) |
I'm going ahead to merge this one after incorporating the feedback! TY 👍🏻 |
If real traffic happens from document, testing, demo etc will suffer domain owners. This is especially true for sites like MDN, which are used by many users. When you require some context, |
We should be using example domains instead of real URLs where possible.