Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add demo for Window Management API #225

Merged
merged 7 commits into from
Oct 18, 2023

Conversation

chrisdavidmills
Copy link
Contributor

The Window Management API was implemented in Chrome 100 (see ChromeStatus entry); this PR provides a basic demo to demonstrate usage.

Copy link

@michaelwasserman michaelwasserman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you very much! I left some comments that I hope are helpful, and I'm happy to circle back with another look or discussion as appropriate.

window-management-api/index.js Show resolved Hide resolved
window-management-api/index.js Outdated Show resolved Hide resolved
window-management-api/index.js Outdated Show resolved Hide resolved
window-management-api/index.js Outdated Show resolved Hide resolved
window-management-api/index.js Outdated Show resolved Hide resolved
window-management-api/index.js Show resolved Hide resolved
@chrisdavidmills
Copy link
Contributor Author

chrisdavidmills commented Oct 16, 2023

Thanks a lot for the review @michaelwasserman. I've implemented all suggested changes, and tested that the demo still works as intended.

Tomorrow my first job will be to check that these changes are also made in the docs code listings.

Copy link

@michaelwasserman michaelwasserman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm fwiw, ty!

@Rumyra Rumyra merged commit 3e75d61 into mdn:main Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants