-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add demo for Window Management API #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you very much! I left some comments that I hope are helpful, and I'm happy to circle back with another look or discussion as appropriate.
Thanks a lot for the review @michaelwasserman. I've implemented all suggested changes, and tested that the demo still works as intended. Tomorrow my first job will be to check that these changes are also made in the docs code listings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm fwiw, ty!
…om-examples into window-management-demo
The Window Management API was implemented in Chrome 100 (see ChromeStatus entry); this PR provides a basic demo to demonstrate usage.