Update child.html #128
Closed
Update child.html #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example could be improved. While fiddling with the 'border-top' field, changing it to 'border-left' or 'border-right' created a border that ran past ALL four link fields. Changing it to 'border-bottom' created lines under the first and fourth link fields. Changing 'border-top: 5px solid red;' to a simple 'color: red;' resulted in ALL four links turning red. This is because the '<ol>' section is within the second '<li>' field, which itself is a direct child of '<ul>'. I think a better example would not have the '<ol>' section nested within the second link of the '<ul>' section, and use a simple 'color: red;' styling. Then, removing the '>' demonstrates direct children vs all children. And fiddling is simplified.
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
added
the
idle
|
Thanks for opening this one, and sorry it was delayed in reviewing. I think it's better to close this one for now as there are conflicts, and (importantly) this is no longer referenced in the MDN content. It's now moved in-page in https://developer.mozilla.org/en-US/docs/Learn_web_development/Core/Styling_basics/Combinators#descendant_combinator Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example could be improved. While fiddling with the 'border-top' field, changing it to 'border-left' or 'border-right' created a border that ran past ALL four link fields instead of just the first two. Changing it to 'border-bottom' created a border under the first and fourth link fields. Changing 'border-top: 5px solid red;' to a simple 'color: red;' resulted in ALL four links turning red. This is because the '<ol>' section is within the second '<li>' field, which itself is a direct child of '<ul>'.
I think a better example would not have the '<ol>' section nested within the second link, but rather nested within the '<ul>' section itself; and use a simple 'color: red;' styling. Then, removing the '>' demonstrates child combinator vs descendant combinator. And fiddling is simplified.
If this commit is accepted, slight changes will also be needed to the text in:
'en-US/docs/Learn/CSS/Building_blocks/Selectors/Combinators'