-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial content of the EyeDropper API #9985
Conversation
Preview URLs
FlawsNone! 🎉 External URLsURL:
URL: No new external URLs URL: No new external URLs URL: No new external URLs (this comment was updated 2021-10-29 06:34:59.657966) |
Thanks @captainbrosset ! I'll take a look.
The BCD should include a Then the page needs to include:
For example:
Yes. |
Thanks Will. Because the BCD data points to MDN (with the |
For information, the BCD pull request I opened the other day got merged, which is great. But if I'm not mistaken it takes a while for this data to be available to MDN. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @captainbrosset !
Yes, it might take up to a week or even a little more (BCD is released weekly, and then a new MDN deployment has to be made). |
Thank you Will for the thorough review. 2 things are remaining:
|
Yes, these should be added. In BCD you should have something like:
I'm not quite familiar with the exact details of how BCD changes make it into mdn/content, but this addition to BCD was in BCD release 4.0.8, which was made a few days ago: mdn/browser-compat-data#13122 ...and I just tried referring to the EyeDropper data from inside an MDN from the head revision of mdn/content, and it worked: ...so I reckon it will be OK. |
Ah, thanks for checking! Silly me, I had forgotten to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks great, that you @captainbrosset !
Summary
This adds some initial documentation content for the EyeDropper API.
The suggestion to add docs for this API was made in issue #9955.
Motivation
The API is implemented in Chromium-based browsers, and can therefore already be used (Chrome 95+ or Edge 95+ for example).
Metadata
Note
This is my first time creating an entirely new API documentation on MDN, so let me know if I forgot some pages or messed up some cross-linking.
Also, I'm not sure I understand how to add the spec section on all of the new pages.
Finally, there isn't any BCD data yet to go with this. I suppose this needs to be done separately in the BCD repository.