Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(modules): remove outdated .mjs notes #9333

Merged
merged 1 commit into from
Sep 29, 2021
Merged

docs(modules): remove outdated .mjs notes #9333

merged 1 commit into from
Sep 29, 2021

Conversation

dabuside
Copy link
Contributor

typescripts now supports .mjs
microsoft/TypeScript#27957

Issue number that this PR fixes (if any). For example: 'Fixes #987654321'

no

What was wrong/why is this fix needed? (quick summary only)

typescripts now supports .mjs.
checkout this PR

Anything else that could help us review it

@dabuside dabuside requested a review from a team as a code owner September 29, 2021 09:04
@dabuside dabuside requested review from Rumyra and removed request for a team September 29, 2021 09:05
@github-actions github-actions bot added the Content:JS JavaScript docs label Sep 29, 2021
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/JavaScript/Guide/Modules
Title: JavaScript modules
on GitHub
Flaw count: 2

  • broken_links:
    • Is currently http:// but can become https://
  • bad_bcd_links:
    • no explanation!

External URLs

URL: /en-US/docs/Web/JavaScript/Guide/Modules
Title: JavaScript modules
on GitHub

No new external URLs

@Rumyra
Copy link
Collaborator

Rumyra commented Sep 29, 2021

Thanks so much @dabuside for your contribution!

@Rumyra Rumyra merged commit 54818b7 into mdn:main Sep 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Rumyra Rumyra Rumyra approved these changes

Assignees
No one assigned
Labels
Content:JS JavaScript docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dabuside @Rumyra