Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GitHub Action cache keys for node_modules unique per workflow #8012

Merged
merged 5 commits into from
Aug 17, 2021
Merged

Make GitHub Action cache keys for node_modules unique per workflow #8012

merged 5 commits into from
Aug 17, 2021

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented Aug 17, 2021 •
edited
Loading

Fixes #8014

Now, the cache keys for caching node_modules is unique per each .yml file so you shouldn't be getting that error.

@peterbe peterbe requested review from a team and schalkneethling and removed request for a team August 17, 2021 14:13
@peterbe peterbe changed the title Why no node modules cache Make GitHub Action cache keys for node_modules unique per workflow Aug 17, 2021
@peterbe peterbe merged commit ff6fe5a into mdn:main Aug 17, 2021
@peterbe peterbe deleted the why-no-node_modules-cache branch August 17, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schalkneethling schalkneethling Awaiting requested review from schalkneethling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node_modules caching in GitHub Actions often fails
1 participant
@peterbe