Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of alert() in Window.find() #7686

Merged
merged 1 commit into from
Aug 7, 2021

Conversation

AnilSeervi
Copy link
Contributor

Fixes a portion of #7566.

@AnilSeervi AnilSeervi requested a review from a team as a code owner August 7, 2021 13:01
@AnilSeervi AnilSeervi requested review from sideshowbarker and removed request for a team August 7, 2021 13:01
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2021

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/Window/find
Title: Window.find()
on GitHub

No new external URLs

@sideshowbarker sideshowbarker merged commit 4c065de into mdn:main Aug 7, 2021
@AnilSeervi AnilSeervi deleted the patch-4 branch August 7, 2021 17:41
wbamberg added a commit to wbamberg/content that referenced this pull request Sep 10, 2021
* upstream/main: (87 commits)
  Update formdata and touchstart macros (mdn#7713)
  Corrected sentence in Streams API overview (mdn#7712)
  Fix broken link (mdn#7711)
  Replace SVGMatrix with DOMMatrix (mdn#7710)
  Removed example covered by other examples (mdn#7706)
  Remove last link to NameList (mdn#7708)
  Delete DOMObject (mdn#7701)
  Remove <dl> list for return value of DOMException() (mdn#7699)
  Fix broken links in Glossary (mdn#7692)
  Fix broken link to NSS/FAQ (mdn#7709)
  Update DOM intro (DOM is no more different in each browsers) (mdn#7705)
  Update Touch() contructor syntax (mdn#7702)
  Replace usage of alert() in File.name(mdn#7703)
  Replace usage of alert() in KeyboardEvent.metaKey(mdn#7704)
  Replace usage of alert() in DOMException() (mdn#7698)
  Remove unnecessary <code> tag (mdn#7697)
  Fix mixin example in Object.create() article (mdn#7631)
  Replace usage of alert() in EventListener (mdn#7690)
  Fix link from Element to Document.querySelectorAll (mdn#7688)
  Replace usage of alert() in Window.find() (mdn#7686)
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants