-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FF91 - Update docs with Feature-Policy: Gamepad and secure context #7269
Conversation
Preview URLs
FlawsNote! 4 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
External URLsURL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs (this comment was updated 2021-07-26 09:10:51.425155) |
Is it really needed to warn on all pages? Would it be sufficient enough to have the banner on interface pages and navigator.getGamepads? |
@Elchi3 Technically it depends on how you come to the information. But I agree that almost always you will first come to the interface page, and then to methods etc. I will assume your comment is "policy" and fix up appropriately. Thanks. |
I'm not sure if this is our policy but I think it should be. See also #7070 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice! 👍
FF91 starts protecting the gamepad API using
Feature-Policy: gamepad
, and also only allows this to be called in secure contexts. This PRMore context can be found in #6723