-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove documentation for the RTCIceComponent enum #6460
Conversation
Preview URLs
FlawsNote! 1 document with no flaws that don't need to be listed. 🎉 URL:
URL:
External URLsURL: No new external URLs URL: No new external URLs URL: No new external URLs (this comment was updated 2021-06-30 01:53:38.912281) |
This one now needs rebasing, it seems |
Rebase complete! |
Does that mean, item 3 in https://github.com/mdn/content#pull-request-etiquette is no longer valid? |
I didn’t know we had such a guideline, and so I’ve never followed it. And it runs counter to best practices, so I’d be interested to understand the rationale for it, rather than just following it. Making additional commits is not a typical or practical way to deal with the common case when rebasing is necessary. |
Okay, let's continue in https://github.com/mdn/content/discussions/6480. |
This PR removes the documentation for the
RTCIceComponent
enum, folding its data intoRTCIceCandidate.component
. This is to go along with this enum's removal in BCD, see mdn/browser-compat-data#11062.