Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove documentation for the RTCIceComponent enum #6460

Merged
merged 2 commits into from
Jun 30, 2021
Merged

Remove documentation for the RTCIceComponent enum #6460

merged 2 commits into from
Jun 30, 2021

Conversation

queengooborg
Copy link
Collaborator

This PR removes the documentation for the RTCIceComponent enum, folding its data into RTCIceCandidate.component. This is to go along with this enum's removal in BCD, see mdn/browser-compat-data#11062.

@queengooborg queengooborg requested review from a team as code owners June 29, 2021 20:07
@queengooborg queengooborg requested review from Rumyra and removed request for a team June 29, 2021 20:07
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2021

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/RTCIceCandidate
Title: RTCIceCandidate
on GitHub
Flaw count: 2

  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase

URL: /en-US/docs/Web/API/RTCIceTransport/component
Title: RTCIceTransport.component
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/RTCIceComponent redirects to /en-US/docs/Web/API/RTCIceCandidate/component
  • broken_links:
    • Anchor not lowercase

External URLs

URL: /en-US/docs/Web/API/RTCIceCandidate
Title: RTCIceCandidate
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/RTCIceCandidate/component
Title: RTCIceCandidate.component
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/RTCIceTransport/component
Title: RTCIceTransport.component
on GitHub

No new external URLs

(this comment was updated 2021-06-30 01:53:38.912281)

@sideshowbarker
Copy link
Collaborator

This one now needs rebasing, it seems

@queengooborg
Copy link
Collaborator Author

Rebase complete!

@sideshowbarker sideshowbarker merged commit 44feafa into mdn:main Jun 30, 2021
@queengooborg queengooborg deleted the remove-RTCIceComponent branch June 30, 2021 02:02
@Ryuno-Ki
Copy link
Collaborator

This one now needs rebasing, it seems

Does that mean, item 3 in https://github.com/mdn/content#pull-request-etiquette is no longer valid?

@sideshowbarker
Copy link
Collaborator

Does that mean, item 3 in mdn/content#pull-request-etiquette is no longer valid?

I didn’t know we had such a guideline, and so I’ve never followed it. And it runs counter to best practices, so I’d be interested to understand the rationale for it, rather than just following it.

Making additional commits is not a typical or practical way to deal with the common case when rebasing is necessary.

@Ryuno-Ki
Copy link
Collaborator

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants