Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rid of mdn.mozillademos.org (part 9) #6025

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented Jun 15, 2021

What was wrong/why is this fix needed? (quick summary only)

Lots of samples use the deprecated https://mdn.mozillademos.org/files/... URLs.

MDN URL of the main page changed

See preview URLs in review companion

Issue number (if there is an associated issue)

n/a

Anything else that could help us review it

See existing ongoing work: https://github.com/mdn/content/pulls?q=is%3Apr+is%3Aclosed+mdn.mozillademos.org

@peterbe peterbe requested a review from a team as a code owner June 15, 2021 14:21
@peterbe peterbe requested review from wbamberg and removed request for a team June 15, 2021 14:21
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 7 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Window/prompt
Title: Window.prompt()
on GitHub
Flaw count: 5

  • macros:
    • /en-us/docs/web/api/globalcrypto (url: /en-US/docs/Web/API/GlobalCrypto) does not exist
    • /en-us/docs/web/api/speechsynthesisgetter (url: /en-US/docs/Web/API/SpeechSynthesisGetter) does not exist
    • /en-us/docs/web/api/windowmodal (url: /en-US/docs/Web/API/WindowModal) does not exist
    • /en-us/docs/web/api/onerroreventhandlerforwindow (url: /en-US/docs/Web/API/OnErrorEventHandlerForWindow) does not exist
    • /en-us/docs/web/api/chromewindow (url: /en-US/docs/Web/API/ChromeWindow) does not exist

URL: /en-US/docs/Web/API/XMLHttpRequest/error_event
Title: XMLHttpRequest: error event
on GitHub
Flaw count: 1

  • broken_links:
    • Anchor not lowercase

URL: /en-US/docs/Web/API/XMLHttpRequest/abort_event
Title: XMLHttpRequest: abort event
on GitHub
Flaw count: 1

  • broken_links:
    • Anchor not lowercase

URL: /en-US/docs/Web/API/Screen/availHeight
Title: Screen.availHeight
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/Window/height does not exist

External URLs

URL: /en-US/docs/Web/API/Window/prompt
Title: Window.prompt()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Canvas_API/Tutorial/Drawing_shapes
Title: Drawing shapes with canvas
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Canvas_API/Tutorial/Transformations
Title: Transformations
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Canvas_API/Tutorial/Applying_styles_and_colors
Title: Applying styles and colors
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/DOMMatrixReadOnly/scale
Title: DOMMatrixReadOnly.scale()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/DOMMatrixReadOnly/translate
Title: DOMMatrixReadOnly.translate()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/DOMMatrixReadOnly/flipX
Title: DOMMatrixReadOnly.flipX()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/XMLHttpRequest/error_event
Title: XMLHttpRequest: error event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/XMLHttpRequest/abort_event
Title: XMLHttpRequest: abort event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/CSSImageValue
Title: CSSImageValue
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Screen/availHeight
Title: Screen.availHeight
on GitHub

No new external URLs

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Peter!
(I was puzzling over why some of these worked when you hadn't added the images. Turned out the images had already been added before, but the paths weren't updated.)

@wbamberg wbamberg merged commit c63c131 into mdn:main Jun 15, 2021
@peterbe peterbe deleted the rid-of-mdnmozillademosorg-part-9 branch June 16, 2021 00:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants