-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace spec table with {{specifications}} for api/[ij]* #5952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoli2003
changed the title
Replace spec table with {{specifications}} for api/[ij]* [DRAFT]
Replace spec table with {{specifications}} for api/[ij]*
Jun 13, 2021
hamishwillee
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
- I like that we're not putting tags around
{{Specifications}}
. - I checked the source updates are all good. I did not however look at every page to confirm the specifications table rendered. Spot check showed they were good though and I see that you have PRs on some missing ones, so I trust you were thorough :-)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1146.
This converts the interface, properties & methods of the remaining api/[ij]* to the {{Specifications}} macros.
Note that:
InputDeviceCapabilities()
has no spec_url. Fix in Add spec_url to InputDeviceCapabilities constructor browser-compat-data#10991InterventionReportBody
has no bcd at all. @rachelandrew is working in fixing it in Adds reporting API and other reports browser-compat-data#10925 (\o/)InputDeviceInfo
andInputDeviceInfo
has no spec_url. Fix in Add spec_url to InputDeviceInfo(.*) browser-compat-data#10992IDBTransaction.durability
andIDBChangeVersionEvent()
. I opened Fix IDBTransaction.durability and add IDBChangeVersionEvent() browser-compat-data#10993 to get them fixed.All other pages look fine.