Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IDs from CSS docs, part 1 #5923

Merged
merged 1 commit into from
Jun 12, 2021
Merged

Remove IDs from CSS docs, part 1 #5923

merged 1 commit into from
Jun 12, 2021

Conversation

wbamberg
Copy link
Collaborator

Part of #5865 .

In preparation for Markdown, I'd like to remove id attributes in our CSS docs that are not attached to headings. This is the first part of that work. I've tried to find places where other pages are using these IDs as fragments and updated them to make as much sense as possible.

@wbamberg wbamberg requested a review from a team as a code owner June 12, 2021 03:48
@wbamberg wbamberg requested review from rachelandrew and removed request for a team June 12, 2021 03:48
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 11 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/shape-outside
Title: shape-outside
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/CSS/calc redirects to /en-US/docs/Web/CSS/calc()
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/box_model
    • Can't resolve /en-US/docs/Web/CSS/CSS_Shapes/Shapes_From_Box_Values

URL: /en-US/docs/Web/CSS/@font-face/src
Title: src
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/url redirects to /en-US/docs/Web/CSS/url()

URL: /en-US/docs/Web/CSS/background-position
Title: background-position
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/background-position-inline does not exist
    • /en-US/docs/Web/CSS/background-position-block does not exist

URL: /en-US/docs/Web/CSS/background-clip
Title: background-clip
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/box_model

URL: /en-US/docs/Web/CSS/background-color
Title: background-color
on GitHub
Flaw count: 2

  • broken_links:
    • Anchor not lowercase
    • Can't resolve /en-US/docs/Web/CSS/CSS_Background_and_Borders/Using_CSS_multiple_backgrounds

URL: /en-US/docs/Web/CSS/background-size
Title: background-size
on GitHub
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/CSS
    • Is currently http:// but can become https://
    • Can't resolve /en-US/docs/Web/CSS/CSS_Backgrounds_and_Borders/Scaling_background_images
    • Can't resolve /en-US/docs/CSS/Scaling_background_images

URL: /en-US/docs/Web/CSS/background-image
Title: background-image
on GitHub
Flaw count: 13

  • macros:
    • /en-US/docs/Web/CSS/cross-fade redirects to /en-US/docs/Web/CSS/cross-fade()
    • /en-US/docs/Web/CSS/element redirects to /en-US/docs/Web/CSS/element()
    • /en-US/docs/Web/CSS/imagefunction redirects to /en-US/docs/Web/CSS/image()
    • /en-US/docs/Web/CSS/image-set redirects to /en-US/docs/Web/CSS/image-set()
    • /en-US/docs/Web/CSS/linear-gradient redirects to /en-US/docs/Web/CSS/linear-gradient()
    • and 5 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/CSS/Using_multiple_backgrounds
    • Anchor not lowercase
    • Can't resolve /en-US/docs/Web/Guide/CSS/CSS_Image_Sprites

URL: /en-US/docs/Web/CSS/Attribute_selectors
Title: Attribute selectors
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/attr redirects to /en-US/docs/Web/CSS/attr()

URL: /en-US/docs/Web/CSS/animation
Title: animation
on GitHub
Flaw count: 5

  • macros:
    • /en-US/docs/Web/CSS/single-transition-easing-function does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/CSS/Using_CSS_transitions#Which_CSS_properties_are_animatable
    • Can't resolve /en-US/docs/Web/Guide/CSS/Using_CSS_transitions
    • Anchor not lowercase
    • Anchor not lowercase

External URLs

URL: /en-US/docs/Web/CSS/shape-outside
Title: shape-outside
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/@font-face/src
Title: src
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/background-attachment
Title: background-attachment
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/border
Title: border
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/angle
Title: <angle>
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/basic-shape
Title: <basic-shape>
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/box-shadow
Title: box-shadow
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/@font-feature-values
Title: @font-feature-values
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/background-position
Title: background-position
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/background
Title: background
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/background-clip
Title: background-clip
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/background-color
Title: background-color
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/border-image-slice
Title: border-image-slice
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/:out-of-range
Title: :out-of-range
on GitHub

URL: /en-US/docs/Web/CSS/background-size
Title: background-size
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/border-radius
Title: border-radius
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/background-image
Title: background-image
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/Attribute_selectors
Title: Attribute selectors
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/:in-range
Title: :in-range
on GitHub

URL: /en-US/docs/Web/CSS/animation
Title: animation
on GitHub

No new external URLs

rachelandrew
rachelandrew approved these changes Jun 12, 2021
View reviewed changes
Copy link
Collaborator

@rachelandrew rachelandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - I wonder if we will find that people have linked to some of these ids from other docs. I'll keep an eye out.

@rachelandrew rachelandrew merged commit 2fcd5a9 into mdn:main Jun 12, 2021
This was referenced Aug 1, 2021
Merged
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2022
@wbamberg wbamberg deleted the remove-css-ids branch October 15, 2022 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rachelandrew rachelandrew rachelandrew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbamberg @rachelandrew