Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Web/JavaScript/Guide/Regular_Expressions #4847

Conversation

mfuji09
Copy link
Contributor

@mfuji09 mfuji09 commented May 10, 2021

What was wrong/why is this fix needed? (quick summary only)

  • The second exec() in "Using regular expressions in JavaScript" should be test().
  • There are a lot of  s which should be normal spaces.
  • Resolved some redirect links.

MDN URL of main page changed

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions

- fix exec() to test()
- replace \  with normal space
- correct links
@mfuji09 mfuji09 requested a review from a team as a code owner May 10, 2021 01:29
@mfuji09 mfuji09 requested review from sideshowbarker and removed request for a team May 10, 2021 01:29
@github-actions
Copy link
Contributor

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good (though I can't see the problem or change made for "The second exec() in "Using regular expressions in JavaScript" should be test().").

Thanks very much!

@hamishwillee hamishwillee merged commit 40d8c8f into mdn:main May 10, 2021
@mfuji09 mfuji09 deleted the 20210510-Web/JavaScript/Guide/Regular_Expressions branch May 10, 2021 16:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants