-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mentions of historic Accept-Charset
header
#4250
Conversation
Over in BCD, we're inclined to drop `Accept-Charset`. Browsers haven't sent this header for many, many years. After giving it some thought I think mentioning in this decade confuses more than informs. mdn/browser-compat-data#9610 (comment)
@wbamberg Perhaps of interest to you, since you and I chatted about it previously. |
FWIW If it were me I would keep the Why? Well, the header is still in live specs, and at some point people will reasonably search for it - resulting in "why haven't you got information on this" questions. I'd rather we had a minimal placeholder that explains that it exists but should not be used and that we have deliberately decided not to include info for it everywhere. |
I'm more set on removing the BCD than I am removing the page. It meets all our criteria for removal and is the last feature between us and a stronger data quality check. So if we let the page stand, then we'd have to drop the compat section and, with the progress being made on generated spec tables, the specifications would go someday too. It's a very thin page at that point. |
@ddbeck Perhaps I wasn't clear in #4250 (comment) - I am absolutely happy with removing BCD and most of this cleanup. I am also already suggesting a much much thinner version of the doc - so that does not phase me. Essentially the difference is that in your proposal the header is missing even though it is in the specification - so we look like we're doing a crap job, and there is no way for anyone to know they shouldn't use it. With my proposal people can find the doc which says "don't use this". Does that make sense? |
I think I agree with Hamish's proposal here. For something that was supported, but not isn't, it is useful to have a page available with a definitive conclusion on it of "this isn't supported, don't use this". Having nothing would lead to uncertainty. In the past, the main cases in which we've removed pages are cases in which something was documented early, but then was never actually implemented. That's a bit different. |
For some reason, the preview comment doesn't mention the page, but I've reinstated it, revised a little, and dropped most of its content: https://pr4250.content.dev.mdn.mozit.cloud/en-US/docs/Web/HTTP/Headers/Accept-Charset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddbeck Works for me (so approved). How about we add a deprecation warning up the top like this:
{{Deprecated_Header}}
<div class="notecard warning">
<h4>Warning</h4>
<p>Do not use this header. It has not sent by any major browser for many years and should be ignored by servers.</p>
</div>
@hamishwillee I tried your suggestion, but |
Awesome. Thanks! |
Over in BCD, we're inclined to drop
Accept-Charset
. Browsers haven't sent this header for many, many years (IE since 2008, Chrome since 2013). After giving it some thought, I think mentioning in this decade confuses more than informs. Some text I removed makes a pretty good case for me:Nobody ought to send this header, servers ought to ignore it, and it's interesting mostly as a historic artifact. This PR scrubs most mentions of the header (except as one of the forbidden header names) and deletes the reference page.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept-Charset