Skip to content

CSS module: writing modes #41539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 17, 2025
Merged

CSS module: writing modes #41539

merged 13 commits into from
Oct 17, 2025
+193 −3

Conversation

estelle
Copy link
Member

@estelle estelle commented Oct 15, 2025

@estelle estelle requested a review from a team as a code owner October 15, 2025 10:01
@estelle estelle requested review from chrisdavidmills and removed request for a team October 15, 2025 10:01
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Oct 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025 •
edited
Loading

Preview URLs

Flaws (3)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/CSS_writing_modes
Title: CSS writing modes
Flaw count: 3

  • broken_links:
    • /en-US/docs/Web/CSS/ is a redirect
  • macros:
    • Can't resolve /en-US/docs/Web/CSS/glyph-orientation-vertical
    • Macro produces link /en-US/docs/Glossary//Baseline/Typography which is a redirect

(comment last updated: 2025-10-17 11:38:33)

chrisdavidmills
chrisdavidmills requested changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. This is going in the right direction; just a few suggestions to consider.

@estelle
Copy link
Member Author

estelle commented Oct 15, 2025

Thanks @chrisdavidmills. I reworded the guide a bit and added headers, to make it clearer.

I am very excited about my explanation on this PR. 🥂🥳🎉🍾

chrisdavidmills
chrisdavidmills requested changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better, nice work @estelle. A few more suggestions for you, mainly around more concretely associating the dimension/direction stuff with the linline/block box stuff.

estelle
estelle commented Oct 16, 2025
View reviewed changes
estelle
estelle commented Oct 16, 2025
View reviewed changes
github-actions[bot]
github-actions bot reviewed Oct 16, 2025
View reviewed changes
estelle and others added 3 commits October 16, 2025 18:01
@estelle @github-actions
Update files/en-us/web/css/css_writing_modes/writing_mode_systems/ind…
02e0ee5 
…ex.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@estelle
Merge branch 'main' into csswm
7fd0d34
@estelle
Merge branch 'main' into csswm
9fc21ff
chrisdavidmills
chrisdavidmills approved these changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle I've got a few more suggestions for you to look at, but I am going to approve this one. Awesome work!

estelle
estelle commented Oct 17, 2025
View reviewed changes
@estelle estelle merged commit 5f406af into main Oct 17, 2025
13 checks passed
@estelle estelle deleted the csswm branch October 17, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees

No one assigned

Labels

Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OWD Project: CSS specs: module landing pages

2 participants

@estelle @chrisdavidmills