-
Notifications
You must be signed in to change notification settings - Fork 22.9k
Only use example.com as example domain #41428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
files/en-us/web/http/reference/headers/access-control-allow-headers/index.md
Outdated
Show resolved
Hide resolved
| 1. You visit `a-shopping-site.example`, which uses `ad-tracker.example` to deliver its adverts on the web. `ad-tracker.example` sets a cookie associated with the `ad-tracker.example` domain. While you are on `a-shopping-site.example`, `ad-tracker.example` receives information about the products you browse. | ||
| 2. You now visit `a-news-site.example` that uses `ad-tracker.example` to deliver adverts. `ad-tracker.example` read its cookie and use the information collected from `a-shopping-site.example` to decide which adverts to display to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dotproto any thoughts on this? Does it make the examples to unrealistic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW I don't much like .example as a TLD, as it is so unexpected (same applies in the XSS guide). But if it's the consensus, I would go along with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, this was also my initial read here, but I think it's the right call.
|
This pull request has merge conflicts that must be resolved before it can be merged. |
2f95904 to
c21d41b
Compare
|
Hi everyone! Since we can't agree on using the .example TLD I'm removing it from this PR, and only working on the cases where the domain name itself has no meaning and can be replaced with example.com. |
Remove a lot of example domains that may happen to be valid, to fix #39865. It is impossible to find all such examples, but I found a good bunch.