FF139 ExprFeat: Escape < and > in attributes when serialize HTML#39363
Merged
hamishwillee merged 2 commits intomdn:mainfrom May 5, 2025
Merged
FF139 ExprFeat: Escape < and > in attributes when serialize HTML#39363hamishwillee merged 2 commits intomdn:mainfrom
hamishwillee merged 2 commits intomdn:mainfrom
Conversation
github-actions
bot
added
Content:Firefox
Contributor
|
Preview URLs Flaws (1)URL:
External URLs (1)URL:
(comment last updated: 2025-05-05 00:14:05) |
8 tasks
dipikabh
approved these changes
May 2, 2025
Comment on lines
+1114
to
+1116
| This prevents certain exploits where HTML is serialized and then injected back into the DOM. | ||
| The affected methods and properties are: {{domxref("Element.innerHTML")}}, {{domxref("Element.outerHTML")}}, {{domxref("Element.getHTML()")}}, {{domxref("ShadowRoot.innerHTML")}}, and {{domxref("ShadowRoot.getHTML()")}}. | ||
| ([Firefox bug 1941347](https://bugzil.la/1941347)) |
Contributor
There was a problem hiding this comment.
Same suggestions as in #39364 (review)
And don't miss the period at the end after the bug link :)
hamishwillee
commented
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FF139 escapes
<as<and>as>in attribute values when HTML is serialized (i.e. when reading Element.innerHTML, Element.outerHTML, Element.getHTML(), ShadowRoot.innerHTML, , ShadowRoot.getHTML().This is the experimental features update.
Related docs can be tracked in #39309