Bug-1381580 cascading locales support release note by rebloor · Pull Request #39013 · mdn/content

rebloor · 2025-04-07T08:54:39Z

Description

Provides a release note for Bug 1381580 "Support multiple fallback locales in i18n API". This change amended the way that localized extensions identified a translation string by cascading through region, language, and then extension default.

github-actions · 2025-04-07T08:56:40Z

Preview URLs

/en-US/docs/Mozilla/Add-ons/WebExtensions/Internationalization

(comment last updated: 2025-04-18 18:31:03)

bsmth

+1 from me, tnx

files/en-us/mozilla/firefox/releases/139/index.md

carlosjeurissen

Suggesting to use properly formatted bcp-47 language tags when possible as this is the default for web.

files/en-us/mozilla/add-ons/webextensions/internationalization/index.md

carlosjeurissen · 2025-04-07T16:34:17Z

files/en-us/mozilla/add-ons/webextensions/internationalization/index.md

-1. if there is a `messages.json` file for the exact current locale, and it contains the string, return it.
-2. Otherwise, if the current locale is qualified with a region (e.g., `en_US`) and there is a `messages.json` file for the regionless version of that locale (e.g., `en`), and that file contains the string, return it.
+1. Return the string if there is a `messages.json` file for the user's set browser locale containing the string. For example, if the user has set their browser to `en_US` and the extension provides an `en_US` `messages.json` file.
+2. Otherwise, if the browser locale is qualified with a script or region (e.g., `en_US` or `zh-Hans-CN`) and there is a `messages.json` file for the regionless version and failing that the scriptless version of that locale and that file contains the string, return it. For example, if the user has set their browser to `zh-Hans-CN`, the i18n system looks for a string in `zh-Hans`, and if that isn't available, `zh.`


Suggested change

2. Otherwise, if the browser locale is qualified with a script or region (e.g., `en_US` or `zh-Hans-CN`) and there is a `messages.json` file for the regionless version and failing that the scriptless version of that locale and that file contains the string, return it. For example, if the user has set their browser to `zh-Hans-CN`, the i18n system looks for a string in `zh-Hans`, and if that isn't available, `zh.`

2. Otherwise, if the browser locale is qualified with a script or region (e.g., `en_US` or `zh-Hans-CN`) and there is a `messages.json` file for the regionless version and failing that the scriptless version of that locale and that file contains the string, return it. For example, if the user has set their browser to `zh-Hans-CN`, the i18n system looks for a string in `zh_Hans-CN`, if unavailable, look for `zh_Hans`, and if that isn't available, `zh.`

@carlosjeurissen given that we've already covered the case of an exact match between the browser's set language and a locale file in point 1, I've rephrased this for clarity.

files/en-us/mozilla/add-ons/webextensions/internationalization/index.md

Co-authored-by: carlosjeurissen <1038267+carlosjeurissen@users.noreply.github.com>

carlosjeurissen

LGTM

github-actions · 2025-04-08T13:55:44Z

This pull request has merge conflicts that must be resolved before it can be merged.

bsmth · 2025-04-11T11:05:42Z

@pepelsbey - this PR is targeting /releases/139. I believe the fix here is updating the base branch to firefox/139, correct?

…multiple-locales-fallbacks # Conflicts: # files/en-us/mozilla/firefox/releases/139/index.md

rebloor · 2025-04-12T17:34:38Z

@bsmth can I clarify your comment

this PR is targeting /releases/139. I believe the fix here is updating the base branch to firefox/139, correct?

Also, is everything OK with the 139 release notes? I got a merge conflict, and on checking, despite the fact that you appeared to have merged it earlier, it isn't listed in the source and now appears to be indicated as added in this PR.

carlosjeurissen · 2025-04-12T17:45:32Z

@rebloor was surprised to see the same. However when checking file changes since all commits, only the PR changes appear.

rebloor · 2025-04-12T17:55:54Z

According to the page commits, it was created by Brian https://github.com/mdn/content/commits/a56169ec1548a24c8d946773b6a645d4726ed74a/files/en-us/mozilla/firefox/releases/139/index.md

pepelsbey · 2025-04-17T11:01:21Z

@rebloor starting from the Firefox 139 release, we’ll be changing the release notes workflow a bit. We keep release notes for upcoming Firefox versions in the firefox/n branch until they are ready and merge them the day before the release. This way, among other things, we’d like to avoid half-baked pages.

Do you mind creating a separate PR with 139 release notes targeting the firefox/139 branch? The release notes file is already there.

Thank you!

Rob--W

Split the 139 notes to a separate PR as requested above, and then this is good to squash and merge.

rebloor · 2025-04-18T07:53:46Z

Release notes now in #39188

Bug-1381580 cascading locales support release note

43cdf1a

rebloor added the Content:WebExt WebExtensions docs label Apr 7, 2025

rebloor requested review from Rob--W and dotproto April 7, 2025 08:54

rebloor self-assigned this Apr 7, 2025

rebloor requested a review from a team as a code owner April 7, 2025 08:54

rebloor requested review from bsmth and removed request for a team April 7, 2025 08:54

github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/xs [PR only] 0-5 LoC changed and removed Content:WebExt WebExtensions docs labels Apr 7, 2025

bsmth approved these changes Apr 7, 2025

View reviewed changes

carlosjeurissen reviewed Apr 7, 2025

View reviewed changes

files/en-us/mozilla/firefox/releases/139/index.md Outdated Show resolved Hide resolved

rebloor added 2 commits April 8, 2025 03:40

Update for review feedback

f7c218c

Clarification to "Localized string selection"

be547bf

rebloor requested a review from a team as a code owner April 7, 2025 16:27

github-actions bot added the Content:WebExt WebExtensions docs label Apr 7, 2025

rebloor requested a review from carlosjeurissen April 7, 2025 16:27

github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Apr 7, 2025

carlosjeurissen reviewed Apr 7, 2025

View reviewed changes

rebloor and others added 2 commits April 8, 2025 14:46

Apply suggestions from review

577a4e1

Co-authored-by: carlosjeurissen <1038267+carlosjeurissen@users.noreply.github.com>

Minor fixes

5d01502

rebloor requested a review from carlosjeurissen April 8, 2025 02:53

carlosjeurissen reviewed Apr 8, 2025

View reviewed changes

github-actions bot added the merge conflicts 🚧 [PR only] label Apr 8, 2025

Merge branch 'main' of ssh://github.com/mdn/content into Bug-1381580-…

a56169e

…multiple-locales-fallbacks # Conflicts: # files/en-us/mozilla/firefox/releases/139/index.md

github-actions bot added size/m [PR only] 51-500 LoC changed and removed merge conflicts 🚧 [PR only] size/s [PR only] 6-50 LoC changed labels Apr 12, 2025

Rob--W approved these changes Apr 17, 2025

View reviewed changes

Remove release notes

37431ec

github-actions bot added size/s [PR only] 6-50 LoC changed and removed Content:Firefox Content in the Mozilla/Firefox subtree size/m [PR only] 51-500 LoC changed labels Apr 18, 2025

rebloor mentioned this pull request Apr 18, 2025

Release notes for Bug-1381580 multiple locales fallbacks #39188

Merged

Merge branch 'main' into Bug-1381580-multiple-locales-fallbacks

d9d0d98

rebloor merged commit dfdfa01 into mdn:main Apr 18, 2025
8 checks passed

rebloor deleted the Bug-1381580-multiple-locales-fallbacks branch April 18, 2025 18:38

Conversation

rebloor commented Apr 7, 2025

Description

Uh oh!

github-actions bot commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bsmth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

carlosjeurissen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

carlosjeurissen Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

rebloor Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

carlosjeurissen left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 8, 2025

Uh oh!

bsmth commented Apr 11, 2025

Uh oh!

rebloor commented Apr 12, 2025

Uh oh!

carlosjeurissen commented Apr 12, 2025

Uh oh!

rebloor commented Apr 12, 2025

Uh oh!

pepelsbey commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rob--W left a comment

Choose a reason for hiding this comment

Uh oh!

rebloor commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions bot commented Apr 7, 2025 •

edited

Loading

rebloor Apr 8, 2025 •

edited

Loading

pepelsbey commented Apr 17, 2025 •

edited

Loading

rebloor commented Apr 18, 2025 •

edited

Loading