Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JSON learning article more technically precise #38644

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

Josh-Cena
Copy link
Member

Fix #36446.

cc @theking2

@Josh-Cena Josh-Cena requested a review from a team as a code owner March 14, 2025 20:56
@Josh-Cena Josh-Cena requested review from dipikabh and removed request for a team March 14, 2025 20:57
@github-actions github-actions bot added Content:Learn Learning area docs size/m [PR only] 51-500 LoC changed labels Mar 14, 2025
Copy link
Contributor

github-actions bot commented Mar 14, 2025

Preview URLs

External URLs (1)

URL: /en-US/docs/Learn_web_development/Core/Scripting/JSON
Title: Working with JSON

(comment last updated: 2025-03-20 21:19:33)

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements, thanks @Josh-Cena!

Co-authored-by: Dipika Bhattacharya <[email protected]>
@Josh-Cena Josh-Cena merged commit 9b7353b into mdn:main Mar 20, 2025
8 checks passed
@Josh-Cena Josh-Cena deleted the fix-json-learn branch March 20, 2025 21:20
bramus pushed a commit to bramus/mdn-content that referenced this pull request Apr 1, 2025
* Make JSON learning article more technically precise

* Apply suggestions from code review

Co-authored-by: Dipika Bhattacharya <[email protected]>

---------

Co-authored-by: Dipika Bhattacharya <[email protected]>
wbamberg added a commit to wbamberg/content that referenced this pull request Apr 4, 2025
* upstream/main: (172 commits)
  chore: improve code style guide (mdn#38715)
  fix: typo on `Error.isError()` page (mdn#38754)
  plural consistency (mdn#38747)
  fix: auto-cleanup by bot (mdn#38695)
  Synchronize with BCD v5.7.4 (mdn#38709)
  Add docs for JS self-profiling API (mdn#37796)
  Better SameSite docs (mdn#38710)
  Added missing explanation for Array Literals (mdn#38745)
  Add a page on CSRF (mdn#38151)
  Fix description of several Range methods (mdn#38518)
  Remove extraneous span (mdn#38696)
  Add a definition for media containers, improve how the media files are defined and Remove wrong information (mdn#38721)
  Move visited selector guide to CSS selectors module (mdn#38642)
  Make JSON learning article more technically precise (mdn#38644)
  Make translate3d() interactive example code valid (mdn#38647)
  Clarity on Safari support for custom elements (mdn#38727)
  feat(css): Link to learning doc about text direction (mdn#38719)
  Fix typo (mdn#38739)
  move guide to module: inline formatting context (mdn#38637)
  Fix CSS pseudo-class lists (mdn#38576)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn Learning area docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the whole article working with JSON could do with a rewrite
2 participants