Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move guide to module: scroll anchoring. #38593

Merged
merged 5 commits into from
Mar 20, 2025
Merged

Move guide to module: scroll anchoring. #38593

merged 5 commits into from
Mar 20, 2025

Conversation

estelle
Copy link
Member

@estelle estelle commented Mar 12, 2025 •
edited
Loading

moved the guide to be in the folder of the new module landing page.
added links to the module

#218

@estelle estelle requested review from a team as code owners March 12, 2025 19:16
@estelle estelle requested review from dipikabh and removed request for a team March 12, 2025 19:16
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries size/s [PR only] 6-50 LoC changed labels Mar 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025 •
edited
Loading

Preview URLs (9 pages)
Flaws (4)

Note! 7 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/CSS_scroll_snap
Title: CSS scroll snap
Flaw count: 2

  • broken_links:
    • /en-US/docs/Glossary/scroll_container is ill cased
  • macros:
    • Macro produces link /en-US/docs/Glossary/scroll_container which is a redirect

URL: /en-US/docs/Web/CSS/CSS_scroll_anchoring/Scroll_anchoring
Title: Understanding scroll anchoring
Flaw count: 2

  • broken_links:
    • /en-US/docs/Glossary/scroll_container is ill cased
  • macros:
    • Macro produces link /en-US/docs/Glossary/scroll_container which is a redirect
External URLs (2)

URL: /en-US/docs/Web/CSS/CSS_scroll_anchoring/Scroll_anchoring
Title: Understanding scroll anchoring

(comment last updated: 2025-03-12 19:45:20)

@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Mar 12, 2025
@sideshowbarker sideshowbarker removed the request for review from a team March 13, 2025 05:05
@estelle estelle requested a review from chrisdavidmills March 13, 2025 19:35
chrisdavidmills
chrisdavidmills requested changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking mostly good, @estelle; just a few small suggestions to consider.

@estelle @chrisdavidmills
committing suggestions
7542983 
Co-authored-by: Chris Mills <[email protected]>
@estelle estelle requested a review from chrisdavidmills March 17, 2025 16:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 17, 2025 •
edited
Loading

Preview URLs (9 pages)
External URLs (2)

URL: /en-US/docs/Web/CSS/CSS_scroll_anchoring/Scroll_anchoring
Title: Understanding scroll anchoring

(comment last updated: 2025-03-18 20:40:52)

@estelle estelle requested a review from dipikabh March 18, 2025 20:39
@dipikabh
Copy link
Contributor

I'll let @chrisdavidmills do the final review

@estelle
Copy link
Member Author

estelle commented Mar 20, 2025

@chrisdavidmills When you have a chance, would love to move this to merged ;)

chrisdavidmills
chrisdavidmills approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle perfect; merging!

@chrisdavidmills chrisdavidmills merged commit a7335ef into main Mar 20, 2025
13 checks passed
@chrisdavidmills chrisdavidmills deleted the mv_saguide branch March 20, 2025 14:53
bramus pushed a commit to bramus/mdn-content that referenced this pull request Apr 1, 2025
@estelle @chrisdavidmills
@dipikabh @bramus
Move guide to module: scroll anchoring. (mdn#38593)
0a9941b 
* Move guide

* add links to new module landing page

* tweaks

* committing suggestions

Co-authored-by: Chris Mills <[email protected]>

* Update files/en-us/web/css/css_scroll_anchoring/scroll_anchoring/index.md

Co-authored-by: Dipika Bhattacharya <[email protected]>

---------

Co-authored-by: Chris Mills <[email protected]>
Co-authored-by: Dipika Bhattacharya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

@dipikabh dipikabh Awaiting requested review from dipikabh

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estelle @dipikabh @chrisdavidmills