Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update non-standard disclaimer #38588

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Mar 12, 2025

Description

Updates the non-standard disclaimer.

Motivation

See: mdn/yari#9774 (comment)

The non-standard disclaimer makes a valid point, but also the wrong discouragement; designing a website to be exactly the same for all browsers, which may have different default behavior, has never been a valid stance.

Additional details

Related issues and pull requests

Port from mdn/yari#11163.

Fixes mdn/yari#9774.

@caugner caugner requested a review from a team as a code owner March 12, 2025 13:01
@github-actions github-actions bot added the size/s [PR only] 6-50 LoC changed label Mar 12, 2025
@caugner caugner requested a review from Rumyra March 12, 2025 13:45
"ru": "Эта возможность не является стандартной и стандартизировать её пока никто не собирается. Не используйте её на сайтах, смотрящих во внешний мир: она будет работать не у всех пользователей. Также могут присутствовать большие несовместимости между реализациями и её поведение может в будущем измениться.",
"zh-CN": "该特性是非标准的,请尽量不要在生产环境中使用它!"
"de": "Wir raten davon ab, diese Funktion auf produktiven Webseiten zu verwenden, da sie nicht bei jedem funktionieren wird.",
"en-US": "We do not recommend using this feature on production sites facing the web because it will not work for everyone.",
Copy link
Collaborator

@hamishwillee hamishwillee Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW This isn't correct and it misses the point of the original issue - which is that you will use this on production sites if you need to. It also will work for everyone if they happen to be on the same browser.

Maybe:

Suggested change
"en-US": "We do not recommend using this feature on production sites facing the web because it will not work for everyone.",
"en-US": "This feature is non-standard. Standard features are preferred, but this may be a suitable alternative on some browsers.",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From MDN's authoritative point of view, I think we should explicitly recommend against using non-standard features on production, and explain why. How about:

Suggested change
"en-US": "We do not recommend using this feature on production sites facing the web because it will not work for everyone.",
"en-US": "We do not recommend using this non-standard feature in production, as it has limited browser support, and may change or be removed.",

cc @Rumyra

Copy link
Collaborator

@hamishwillee hamishwillee Mar 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From MDN's authoritative point of view, I think we should explicitly recommend against using non-standard features on production, and explain why.
Agree with @hamishwillee 's suggestion here

I'm not sure which of these came first :-)

@caugner

  1. This misses the point that the issue specifically argues that the "you can't use in production" is overly prescriptive.
    That is why I've suggested that these can be used in production, albeit under circumstances where it makes sense.
    You might close the issue as invalid if the MDN position is always "we don't recommend in production full stop".
  2. If you do go with something more like yours, then I would make it non-specific to _this non-standard feature" - we apply this everywhere - it isn't really "this" case we're worried about, but the general use.
  3. A possible compromise that could meet both needs:
Suggested change
"en-US": "We do not recommend using this feature on production sites facing the web because it will not work for everyone.",
"en-US": "We do not generally recommend non-standard features in production, as they have limited browser support, and may change or be removed. They may be a suitable alternative in specific cases, where there is no standard alternative.",

@Rumyra
Copy link
Collaborator

Rumyra commented Mar 14, 2025

Agree with @hamishwillee 's suggestion here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-standard disclaimer is incorrectly discouraging
3 participants