Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync feature list for CSS backgrounds and borders module #38063

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Sync feature list for CSS backgrounds and borders module #38063

merged 4 commits into from
Feb 11, 2025

Conversation

skyclouds2001
Copy link
Contributor

Description

Motivation

remove feature that is not this module, and add note about not implemented features

Additional details

https://drafts.csswg.org/css-backgrounds/
https://drafts.csswg.org/css-backgrounds-4/

Related issues and pull requests

@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Feb 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025 •
edited
Loading

Preview URLs

Flaws (144)

URL: /en-US/docs/Web/CSS/CSS_backgrounds_and_borders
Title: CSS backgrounds and borders
Flaw count: 144

  • broken_links:
    • /en-US/docs/Web/CSS/CSS_Animations/Using_CSS_animations is ill cased
    • /en-US/docs/Web/CSS/CSS_Backgrounds_and_Borders/Using_multiple_backgrounds is ill cased
    • /en-US/docs/Web/CSS/CSS_Backgrounds_and_Borders/Resizing_background_images is ill cased
    • /en-US/docs/Web/CSS/CSS_Box_Alignment/Box_Alignment_In_Block_Abspos_Tables is ill cased
    • /en-US/docs/Web/CSS/CSS_Box_Alignment/Box_Alignment_in_Flexbox is ill cased
    • and 67 more flaws omitted
  • macros:
    • Macro produces link /en-US/docs/Web/CSS/CSS_Animations/Using_CSS_animations which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_Backgrounds_and_Borders/Using_multiple_backgrounds which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_Backgrounds_and_Borders/Resizing_background_images which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_Box_Alignment/Box_Alignment_In_Block_Abspos_Tables which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_Box_Alignment/Box_Alignment_in_Flexbox which is a redirect
    • and 67 more flaws omitted

(comment last updated: 2025-02-11 08:51:54)

@skyclouds2001 skyclouds2001 marked this pull request as ready for review February 9, 2025 12:51
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner February 9, 2025 12:51
@skyclouds2001 skyclouds2001 requested review from chrisdavidmills and removed request for a team February 9, 2025 12:51
chrisdavidmills
chrisdavidmills requested changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skyclouds2001 comment for you.

Also, you need to add css-backgrounds-4 to the list of spec URLs. At the moment, only css-backgrounds is in the spec URLs list, which is confusing, as none of the properties mentioned in the "not supported" list are specified there.

files/en-us/web/css/css_backgrounds_and_borders/index.md Outdated Show resolved Hide resolved
chrisdavidmills
chrisdavidmills approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks @skyclouds2001. Let's get it merged.

@chrisdavidmills chrisdavidmills merged commit f43b5c1 into mdn:main Feb 11, 2025
8 checks passed
@skyclouds2001 skyclouds2001 deleted the CSS-backgrounds-and-borders branch February 11, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @chrisdavidmills