Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove guide mutation events #3667

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Conversation

hamishwillee
Copy link
Collaborator

This removes Guide/Events/Mutation_events as part of fixing #2245.

In summary, the guide topic is almost identical to the webapi page MutationEvent. So this mostly just deletes the guide page, updates links to MutationEvent, and adds a redirect to MutationEvent

@hamishwillee hamishwillee requested review from a team as code owners March 30, 2021 06:28
@hamishwillee hamishwillee requested review from chrisdavidmills and removed request for a team March 30, 2021 06:28
@hamishwillee hamishwillee mentioned this pull request Mar 30, 2021
10 tasks
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of teensy commments (just one waaaaafer-thin mint...)

files/en-us/web/guide/events/index.html Outdated Show resolved Hide resolved
files/en-us/web/api/mutationevent/index.html Outdated Show resolved Hide resolved
@@ -81,6 +81,19 @@ <h2 id="Event_index">Event index</h2>
<td>Events fired on <a href="/en-US/docs/Web/API/IDBDatabase#events"><code>IDBDatabase</code></a>, <a href="/en-US/docs/Web/API/IDBOpenDBRequest#events"><code>IDBOpenDBRequest</code></a>, <a href="/en-US/docs/Web/API/IDBRequest#events"><code>IDBRequest</code></a>, <a href="/en-US/docs/Web/API/IDBTransaction#events"><code>IDBTransaction</code></a>.</td>
</tr>

<tr>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisdavidmills Thanks for the review. I fixed up as per your suggestions. This change is new - as previously discussed, addition of mutation events to the event reference with the sole purpose of pointing out that we now use mutation observers for this now.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2021

Preview URLs

Flaws

URL: /en-US/docs/Mozilla/Firefox/Releases/65
Title: Firefox 65 for developers
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/ServiceWorkerGlobalScope/onmessageerror does not exist
    • /en-US/docs/Web/API/ServiceWorkerContainer/onmessageerror does not exist

URL: /en-US/docs/Mozilla/Firefox/Releases/62
Title: Firefox 62 for developers
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Tools/GCLI
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement

URL: /en-US/docs/Web/Guide/Events
Title: Event developer guide
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/Events
Title: Event reference
on GitHub

No flaws! 🎉


URL: /en-US/docs/Web/API/MutationEvent
Title: MutationEvent
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/MutationNameEvent does not exist
    • /en-US/docs/Web/API/MutationNameEvent does not exist
  • bad_bcd_queries:
    • No BCD data for query: api.MutationEvent

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/65
Title: Firefox 65 for developers
on GitHub


URL: /en-US/docs/Mozilla/Firefox/Releases/62
Title: Firefox 62 for developers
on GitHub


URL: /en-US/docs/Web/Guide/Events
Title: Event developer guide
on GitHub

No external URLs

URL: /en-US/docs/Web/Events
Title: Event reference
on GitHub

No external URLs

URL: /en-US/docs/Web/API/MutationEvent
Title: MutationEvent
on GitHub

@hamishwillee
Copy link
Collaborator Author

@chrisdavidmills PS Do you think it is "worth" adding BCD for MutationEvent? Essentially this would show that the Mutation event is more than just deprecated - but actually removed in most places.

My leaning is "not worth it", but you might feel differently.

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is looking good now; thanks @hamishwillee !

I'd agree that MutationEvent BCD is not really worth it.

@chrisdavidmills chrisdavidmills merged commit 9746f59 into mdn:main Apr 6, 2021
@hamishwillee hamishwillee deleted the mutation_events branch April 7, 2021 08:16
@hamishwillee
Copy link
Collaborator Author

@chrisdavidmills

I'd agree that MutationEvent BCD is not really worth it.

Except if we decide that BCD is the canonical source of deprecation info :-0

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants