-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove guide mutation events #3667
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of teensy commments (just one waaaaafer-thin mint...)
@@ -81,6 +81,19 @@ <h2 id="Event_index">Event index</h2> | |||
<td>Events fired on <a href="/en-US/docs/Web/API/IDBDatabase#events"><code>IDBDatabase</code></a>, <a href="/en-US/docs/Web/API/IDBOpenDBRequest#events"><code>IDBOpenDBRequest</code></a>, <a href="/en-US/docs/Web/API/IDBRequest#events"><code>IDBRequest</code></a>, <a href="/en-US/docs/Web/API/IDBTransaction#events"><code>IDBTransaction</code></a>.</td> | |||
</tr> | |||
|
|||
<tr> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrisdavidmills Thanks for the review. I fixed up as per your suggestions. This change is new - as previously discussed, addition of mutation events to the event reference with the sole purpose of pointing out that we now use mutation observers for this now.
@chrisdavidmills PS Do you think it is "worth" adding BCD for MutationEvent? Essentially this would show that the Mutation event is more than just deprecated - but actually removed in most places. My leaning is "not worth it", but you might feel differently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is looking good now; thanks @hamishwillee !
I'd agree that MutationEvent
BCD is not really worth it.
Except if we decide that BCD is the canonical source of deprecation info :-0 |
This removes Guide/Events/Mutation_events as part of fixing #2245.
In summary, the guide topic is almost identical to the webapi page MutationEvent. So this mostly just deletes the guide page, updates links to
MutationEvent
, and adds a redirect toMutationEvent