Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BodyInit also allows ReadableStream #35949

Merged
merged 1 commit into from
Sep 19, 2024
Merged

BodyInit also allows ReadableStream #35949

merged 1 commit into from
Sep 19, 2024

Conversation

mhart
Copy link
Contributor

@mhart mhart commented Sep 19, 2024

Description

The body option supplied to the Request constructor (BodyInit) also allows ReadableStream according to the spec (and implementations)

Motivation

The above option appears to not be documented (unless I missed it?)

@mhart mhart requested a review from a team as a code owner September 19, 2024 05:14
@mhart mhart requested review from Elchi3 and removed request for a team September 19, 2024 05:14
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Sep 19, 2024
Copy link
Contributor

github-actions bot commented Sep 19, 2024

Preview URLs

(comment last updated: 2024-09-19 15:06:37)

@wbamberg
Copy link
Collaborator

Thank you! We also list the types here: https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#setting_a_body , would you mind adding ReadableStream there as well?

@mhart mhart force-pushed the patch-1 branch 2 times, most recently from 95c2ada to d268168 Compare September 19, 2024 11:17
@mhart
Copy link
Contributor Author

mhart commented Sep 19, 2024

Thank you! We also list the types here: https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#setting_a_body , would you mind adding ReadableStream there as well?

Good pickup, thanks @wbamberg – added that too

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @mhart !

@wbamberg wbamberg merged commit 667c188 into mdn:main Sep 19, 2024
8 checks passed
fiji-flo pushed a commit that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants