-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVGGeometryElement.prototype.{isPointInFill,isPointInStroke} #35746
base: main
Are you sure you want to change the base?
Conversation
better parameter destription and examples (work in firefox!)
]; | ||
|
||
for (const point of points) { | ||
let isPointInFill; | ||
|
||
try { | ||
const pointObj = new DOMPoint(point[0], point[1]); | ||
const pointObj = {x: point[0], y: point[1]}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[mdn-linter] reported by reviewdog 🐶
const pointObj = {x: point[0], y: point[1]}; | |
const pointObj = { x: point[0], y: point[1] }; |
]; | ||
|
||
for (const point of points) { | ||
let isPointInStroke; | ||
|
||
try { | ||
const pointObj = new DOMPoint(point[0], point[1]); | ||
isPointInFill = circle.isPointInStroke(pointObj); | ||
const pointObj = {x: point[0], y: point[1]}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[mdn-linter] reported by reviewdog 🐶
const pointObj = {x: point[0], y: point[1]}; | |
const pointObj = { x: point[0], y: point[1] }; |
Preview URLs
Flaws (2)URL:
URL:
(comment last updated: 2024-09-04 17:36:45) |
changed pages:
pointEl.style.r
,pointEl.style.cx
,pointEl.style.cy
because they don't exist in firefoxisPointInFill
variable that is not declared in https://developer.mozilla.org/en-US/docs/Web/API/SVGGeometryElement/isPointInStroke#javascript{ x: point[0], y: point[1] }
instead ofnew DOMPoint(point[0], point[1])
to show that object class doesn't matter in browsers that supportDOMPoint
→DOMPointInit
in parametersWhat does
mean?Adding
pointer-events="none"
orstyle="pointer-events:none"
to big circle has no effect.