Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document javascript: URLs #35599

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Document javascript: URLs #35599

merged 3 commits into from
Aug 27, 2024

Conversation

Josh-Cena
Copy link
Member

Fix #7143

@Josh-Cena Josh-Cena requested review from a team as code owners August 26, 2024 22:24
@Josh-Cena Josh-Cena requested review from pepelsbey, willdurand, sideshowbarker, hamishwillee and chrisdavidmills and removed request for a team August 26, 2024 22:24
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:WebExt WebExtensions docs Content:WebAPI Web API docs Content:JS JavaScript docs Content:Other Any docs not covered by another "Content:" label Content:HTTP HTTP docs Content:Security Security docs Content:Firefox Content in the Mozilla/Firefox subtree labels Aug 26, 2024
@Josh-Cena Josh-Cena requested review from bsmth and removed request for chrisdavidmills August 26, 2024 22:24
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Aug 26, 2024
Copy link
Contributor

github-actions bot commented Aug 26, 2024

Preview URLs (12 pages)
Flaws (3)

Note! 11 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/Sources
Title: CSP source values
Flaw count: 3

  • macros:
    • /en-US/docs/Web/HTTP/Basics_of_HTTP/Identifying_resources_on_the_Web does not exist
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/HTTP/Basics_of_HTTP/Data_URLs
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/HTTP/Basics_of_HTTP/Choosing_between_www_and_non-www_URLs
External URLs (2)

URL: /en-US/docs/Web/URI/Schemes/javascript
Title: javascript: URLs


URL: /en-US/docs/Mozilla/Firefox/Releases/127
Title: Firefox 127 for developers

(comment last updated: 2024-08-27 01:05:39)


## Description

`javascript:` URLs can be used anywhere a URL is a navigation target. This includes, but is not limited to:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to use the code form here, because we're not repeating ourselves after.

@hamishwillee
Copy link
Collaborator

In any case, this is excellent.

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Remaining suggestions were just that. Thank you.

@hamishwillee hamishwillee merged commit 1a48b6a into mdn:main Aug 27, 2024
8 checks passed
@Josh-Cena Josh-Cena deleted the javascript-uri branch August 27, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree Content:HTML Hypertext Markup Language docs Content:HTTP HTTP docs Content:JS JavaScript docs Content:Other Any docs not covered by another "Content:" label Content:Security Security docs Content:WebAPI Web API docs Content:WebExt WebExtensions docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content suggestion: javascript pseudo-protocol identifier
2 participants