Remove window prefix in requestAnimationFrame example #35456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
window prefix unnecessary and inconsistent
github-actions
bot
added
Content:WebAPI
senocular
changed the title
|
Preview URLs |
|
We actually have a whole discussion on this: #27666 and it's unclear whether we want this prefix or not. I don't think it's going to be as smooth as "everyone loves to drop this prefix". |
Josh-Cena
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
@senocular I'm merging this PR since other examples on this page aren't adding the prefix anyway, but we may add them back later, in a consistent fashion, depending on the outcome of the discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window prefix unnecessary and inconsistent
Description
Removes the window prefix from the one example using it.
Motivation
Unnecessary and inconsistent with other examples. Can be confusing why its used in this one example and not in others.
Additional details
Related issues and pull requests