-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New docs area for URL semantics, relocate some HTTP pages here #35202
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Preview URLs (37 pages)
Flaws (18)Note! 31 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
External URLs (6)URL:
URL:
URL:
URL:
URL:
URL:
(comment last updated: 2024-08-26 15:29:45) |
Agreed. At least all the docs are present and it gives us a baseline for discussion. I'm happy enough with it. There are a couple more suggestions there, but I think this is good. Let's see if we can also get review from @bsmth (I'll approve tomorrow) |
Co-authored-by: Hamish Willee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsmth Can you scan this. I think it is good, but extra eyes would be welcome.
@Josh-Cena Approved, but would be good to give Brian a chance to look at it if he is available today.
Co-authored-by: Brian Thomas Smith <[email protected]>
|
||
Any of those URLs can be typed into your browser's address bar to tell it to load the associated page (resource). | ||
|
||
A URL is composed of different parts, some mandatory and others optional. A more complex example might look like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to mention that the parts of a URL are described in detail below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine as-is. The details below aren't directly dependent on this example anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, Josh & Hamish. I'm also +1 on this with some minor nits. Also agree about sidebar improvements, but this is a great start
Co-authored-by: Brian Thomas Smith <[email protected]>
Thanks to you both for the reviews! |
* zh-cn: sync translated content * Move URL related docs to the new area ref: mdn/content#35202 --------- Co-authored-by: allo <[email protected]>
* zh-tw: sync translated content * Move URL related docs to the new area ref: mdn/content#35202 --------- Co-authored-by: allo <[email protected]>
BTW @Josh-Cena there's some fixes to be done on sidebars: mdn/yari#11700 At the moment, adding the links to the new locations, but we should have a think if it makes sense to have these entries here at all (under Resources and URIs). |
Great, thanks! I don't have any opinions on how the HTTP sidebar should be structured. |
I assume I have gotten enough support in https://github.com/orgs/mdn/discussions/700, so this is the first part of the proposal. I have created a new "URL" area, and moved a few HTTP pages that talk about URLs here.