-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Accessibility section above Examples for CSS pages #34985
Conversation
Thank you for suggesting this contribution. I did a search of live pages, and HTML element pages use the heading "Accessibility" while CSS pages and HTML attributes use the heading "Accessibility concerns". So we should not be dropping the "concerns" on these CSS pages. |
I'll ping @dipikabh, just in case I am wrong. |
55a9a99
to
7c5a9ee
Compare
@estelle Hello, thank you for reviewing this pull request. The section title change is in accordance with the decisions taken in the aforementioned discussion and related pull requests. If what was decided has changed, I can revert the renaming of section titles and contribute a new pull request for HTML pages. |
Hi @estelle, we are indeed moving ahead with changing "Accessibility concerns" to "Accessibility" across HTML and CSS pages, as mentioned in these comments (this and this) of the discussion. The idea is to expand the scope of the section to include guidelines (like best practices or tips) that are not necessarily "concerns". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Also, congratulations on your first merged MDN content PR.
Welcome to the team!
Description
Moves Accessibility section above Examples for CSS Function, Property, and Selector pages. Does not change the content of the section.
Motivation
Bring pages in line with template change from #34984, as agreed in github.com/orgs/mdn/discussions/430
Additional details
Full discussion thread: github.com/orgs/mdn/discussions/430
Many pages already had their Accessibility section above Examples or other sections above it.
The following pages and areas have been ignored since they do not follow the CSS page templates:
!important
forced-colors
Related issues and pull requests