Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Accessibility section above Examples for CSS pages #34985

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

mcaskill
Copy link
Contributor

Description

Moves Accessibility section above Examples for CSS Function, Property, and Selector pages. Does not change the content of the section.

Motivation

Bring pages in line with template change from #34984, as agreed in github.com/orgs/mdn/discussions/430

Additional details

Full discussion thread: github.com/orgs/mdn/discussions/430

Many pages already had their Accessibility section above Examples or other sections above it.

The following pages and areas have been ignored since they do not follow the CSS page templates:

Related issues and pull requests

@mcaskill mcaskill requested a review from a team as a code owner July 23, 2024 01:53
@mcaskill mcaskill requested review from estelle and removed request for a team July 23, 2024 01:53
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Jul 23, 2024
@estelle
Copy link
Member

estelle commented Jul 23, 2024

Thank you for suggesting this contribution.

I did a search of live pages, and HTML element pages use the heading "Accessibility" while CSS pages and HTML attributes use the heading "Accessibility concerns". So we should not be dropping the "concerns" on these CSS pages.

@estelle
Copy link
Member

estelle commented Jul 23, 2024

Thank you for suggesting this contribution.

I did a search of live pages, and HTML element pages use the heading "Accessibility" while CSS pages and HTML attributes use the heading "Accessibility concerns". So we should not be dropping the "concerns" on these CSS pages.

I'll ping @dipikabh, just in case I am wrong.

Copy link
Contributor

github-actions bot commented Jul 23, 2024

Preview URLs (73 pages)
External URLs (26)

URL: /en-US/docs/Web/CSS/background
Title: background


URL: /en-US/docs/Web/CSS/list-style
Title: list-style


URL: /en-US/docs/Web/CSS/:focus-visible
Title: :focus-visible


URL: /en-US/docs/Web/CSS/content
Title: content


URL: /en-US/docs/Web/CSS/:focus
Title: :focus


URL: /en-US/docs/Web/CSS/max
Title: max()


URL: /en-US/docs/Web/CSS/image/image-set
Title: image-set()


URL: /en-US/docs/Web/CSS/word-spacing
Title: word-spacing


URL: /en-US/docs/Web/CSS/:empty
Title: :empty


URL: /en-US/docs/Web/CSS/:invalid
Title: :invalid


URL: /en-US/docs/Web/CSS/:optional
Title: :optional


URL: /en-US/docs/Web/CSS/:valid
Title: :valid


URL: /en-US/docs/Web/CSS/:required
Title: :required


URL: /en-US/docs/Web/CSS/::selection
Title: ::selection

(comment last updated: 2024-07-23 18:38:17)

@mcaskill mcaskill requested review from a team as code owners July 23, 2024 15:46
@mcaskill mcaskill requested review from wbamberg and removed request for a team July 23, 2024 15:46
@github-actions github-actions bot added Content:WebAPI Web API docs Content:Accessibility Accessibility docs Content:Meta Content in the meta docs labels Jul 23, 2024
@mcaskill
Copy link
Contributor Author

@estelle Hello, thank you for reviewing this pull request. The section title change is in accordance with the decisions taken in the aforementioned discussion and related pull requests.

If what was decided has changed, I can revert the renaming of section titles and contribute a new pull request for HTML pages.

@dipikabh
Copy link
Contributor

I'll ping @dipikabh, just in case I am wrong.

Hi @estelle, we are indeed moving ahead with changing "Accessibility concerns" to "Accessibility" across HTML and CSS pages, as mentioned in these comments (this and this) of the discussion. The idea is to expand the scope of the section to include guidelines (like best practices or tips) that are not necessarily "concerns".

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
Also, congratulations on your first merged MDN content PR.
Welcome to the team!

@estelle estelle merged commit 3928d2b into mdn:main Jul 23, 2024
8 checks passed
@mcaskill mcaskill deleted the move-a11y-in-css-pages branch July 23, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Accessibility Accessibility docs Content:CSS Cascading Style Sheets docs Content:Meta Content in the meta docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants