Replace alert in Learn/JavaScript/First_steps/Variables #34487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:Learn:JavaScript
27 tasks
|
Preview URLs (comment last updated: 2024-06-28 14:42:27) |
Josh-Cena
reviewed
Jun 28, 2024
Josh-Cena
approved these changes
Jun 28, 2024
|
Thank you! |
wbamberg
added a commit
to wbamberg/content
that referenced
this pull request
Jun 29, 2024
* upstream/main: (58 commits) Update arrow function documentation to clarify naming and assignment (mdn#34501) update fetch guide (mdn#34278) Replace alert in Learn/JavaScript/First_steps/Variables (mdn#34487) Replace alert in MDN/Writing_guidelines/Page_structures/Live_samples (mdn#34479) Fix typo (mdn#34486) Remove SVG color-profile attribute (mdn#34482) Remove SVG enable-background attribute (mdn#34483) Remove SVG kerning attribute (mdn#34475) Updated the description of `targetOrigin` to specify the intended re… (mdn#34114) Mention CSWH in WebSocket server guide (mdn#34411) Add note to CSP sandbox saying allow-top-navigation is redundant (mdn#34415) Mention navigator.languages may be truncated and Accept-Language may have fallback (mdn#34418) Remove IDB output "example", preferring live example (mdn#34464) Mention that pinch-zoom are also wheel events (mdn#34468) Mention that flex-basis is floored at min-content (mdn#34469) More content to Global object glossary (mdn#34471) Fix IDB cursor prev direction description (mdn#34463) Remove all line number references to inline code examples (mdn#34459) Remove link to notification example (mdn#34412) Replaces HTML entity glossary links/mentions with char reference (mdn#34391) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace alert in the introduction to variables in JavaScript. Instead of alerts and prompts I added a counter that counts the number of times the user has clicked a button. The text was also updated for the new example.
Motivation
The current example is broken. Replacing the alert with a counter gives a working example for a basic variable in JavaScript.
Additional details
Related issues and pull requests
Relates to #7566