Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inset-area: property and data type: anchor positioning #6 #34462

Merged
merged 17 commits into from
Jul 3, 2024
Merged

inset-area: property and data type: anchor positioning #6 #34462

merged 17 commits into from
Jul 3, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jun 27, 2024 •
edited
Loading

  • inset-area property
  • inset-area data type

@estelle estelle requested a review from a team as a code owner June 27, 2024 17:23
@estelle estelle requested review from chrisdavidmills and removed request for a team June 27, 2024 17:23
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Jun 27, 2024
@estelle estelle marked this pull request as draft June 27, 2024 17:24
@github-actions github-actions bot added the size/l [PR only] 501-1000 LoC changed label Jun 27, 2024
@estelle estelle mentioned this pull request Jun 27, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 27, 2024 •
edited
Loading

Preview URLs

Flaws (3)

URL: /en-US/docs/Web/CSS/inset-area
Title: inset-area
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/position-try-options does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/inset-area_function

URL: /en-US/docs/Web/CSS/inset-area_value
Title: <inset-area>
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/inset-area_function

(comment last updated: 2024-07-02 18:48:41)

@estelle estelle marked this pull request as ready for review July 2, 2024 03:18
@estelle estelle changed the title Draft: inset-area: anchor positioning #6 inset-area: property and data type: anchor positioning #6 Jul 2, 2024
chrisdavidmills
chrisdavidmills requested changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @estelle! Great work here — I'm really pleased with how these pages have turned out. I've left quite a few comments, but they are mostly grammar nitpicks. Nothing too major.

files/en-us/web/css/inset-area/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/inset-area/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/inset-area/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/inset-area/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/inset-area/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/inset-area_value/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/inset-area_value/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/inset-area_value/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/inset-area_value/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/inset-area_value/index.md Outdated Show resolved Hide resolved
@chrisdavidmills chrisdavidmills mentioned this pull request Jul 2, 2024
Merged
4 tasks
github-actions[bot]
github-actions bot reviewed Jul 2, 2024
View reviewed changes
files/en-us/web/css/inset-area/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/inset-area/index.md Outdated Show resolved Hide resolved
estelle and others added 6 commits July 2, 2024 08:11
@estelle
underlines in links.
bd6620a
@estelle @chrisdavidmills
Apply suggestions from code review
8eab9c4 
Co-authored-by: Chris Mills <[email protected]>
@estelle @github-actions
Update files/en-us/web/css/inset-area/index.md
7ec62ad 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@estelle @github-actions
Apply suggestions from code review
676e530 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@estelle
Merge branch 'main' into css-anchor-positioning-6
869031d
@estelle
promote all headings. span all link
9e09252
estelle
estelle commented Jul 2, 2024
View reviewed changes
Copy link
Member Author

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged all your suggestions, with the three being partial commits as noted in the comments. Anything after this comment is an edit post merging of your suggestions.

files/en-us/web/css/inset-area/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/inset-area_value/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/inset-area_value/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/inset-area_value/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/inset-area_value/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/inset-area_value/index.md Outdated Show resolved Hide resolved
chrisdavidmills
chrisdavidmills requested changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle few more bits for you.

files/en-us/web/css/inset-area_value/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/inset-area/index.md Show resolved Hide resolved
chrisdavidmills
chrisdavidmills approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle brilliant, demos all work, pages looking great. Merging!

@chrisdavidmills chrisdavidmills merged commit 3e41239 into main Jul 3, 2024
9 checks passed
@chrisdavidmills chrisdavidmills deleted the css-anchor-positioning-6 branch July 3, 2024 09:14
@chrisdavidmills chrisdavidmills restored the css-anchor-positioning-6 branch July 3, 2024 09:14
@bsmth
Copy link
Member

bsmth commented Jul 4, 2024

Hey @estelle and @chrisdavidmills for the next one, would it be possible to check the images into the shared-assets repo? I'm deleting .PNG files from mdn/content at every opportunity to keep the repo size down. This would be a great spot for them: https://github.com/mdn/shared-assets/tree/main/images/diagrams

Thanks a lot!

@bsmth bsmth deleted the css-anchor-positioning-6 branch July 4, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/l [PR only] 501-1000 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estelle @bsmth @chrisdavidmills