-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 33356: Document integrity properly #34406
Conversation
Preview URLs (comment last updated: 2024-06-26 08:23:19) |
I'm not sure if this page is the right place to document it as it's a simple reflector of the internal state of the request. It should probably be on the |
I did think about this, and the reason I went with here is that we have a whole page to talk about it here, and it's nice to be able to use that space. If we document it in the constructor or Alternative I suppose would be to create subpages for |
We can either make a tree for I don't have strong opinions against this either. The WebAPI information is really all over the place (especially HTML element stuff). |
I think the best alternative is inline in RequestInit, and I'm happy to try that when it exists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🎉
@wbamberg Do you want to merge this or to move the content to |
I put all the relevant stuff in the other PR: https://pr34437.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/RequestInit#integrity so think we can close this PR without merging. |
Fixes #33356.